Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat rebuild ANTLR bindings #96

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

vEpiphyte
Copy link

@vEpiphyte vEpiphyte commented Dec 26, 2023

  • Update antlr generated content to use antlr 4.13.1
  • Remove six ( since its no longer required )
  • Updated build / test actions to use python 3.11 and python 3.11
  • Updated dev / install documentation.

Binding regeneration:

Using openjdk-19-jre-headless

java -jar ./antlr-4.13.1-complete.jar -Dlanguage=Python3 STIXPattern.g4 -visitor -o ./stix2patterns/v21/grammars
java -jar ./antlr-4.13.1-complete.jar -Dlanguage=Python3 STIXPattern.g4 -visitor -o ./stix2patterns/v20/grammars

Files taken from
https://github.com/oasis-open/cti-stix2-json-schemas/blob/stix2.0/pattern_grammar/STIXPattern.g4
https://github.com/oasis-open/cti-stix2-json-schemas/blob/stix2.1/pattern_grammar/STIXPattern.g4

$ sha256sum STIXPattern.g4*
a5fab115c8973680f13274113ba1d9c1fe5708b00805a06644c7ce717c42ff19  STIXPattern.g4.20
b6429e8fed902133d2409d86c906b0c9dbaa4a54536023997ee73b460876b228  STIXPattern.g4.21

Bindings were committed as is.

The test suite for https://github.com/oasis-open/cti-pattern-matcher and https://github.com/oasis-open/cti-stix-validator pass with these updated bindings.

The tox suite seems to fail on a packaing step. That is unrelated to this PR.

Closes #84

Using openjdk-19-jre-headless

$ sha256sum antlr-4.13.1-complete.jar
bc13a9c57a8dd7d5196888211e5ede657cb64a3ce968608697e4f668251a8487  antlr-4.13.1-complete.jar

Building the bindings

java -jar ./antlr-4.13.1-complete.jar -Dlanguage=Python3 STIXPattern.g4 -visitor -o ./stix2patterns/v21/grammars
java -jar ./antlr-4.13.1-complete.jar -Dlanguage=Python3 STIXPattern.g4 -visitor -o ./stix2patterns/v20/grammars

Files taken from
https://github.com/oasis-open/cti-stix2-json-schemas/blob/stix2.0/pattern_grammar/STIXPattern.g4
https://github.com/oasis-open/cti-stix2-json-schemas/blob/stix2.1/pattern_grammar/STIXPattern.g4

$ sha256sum STIXPattern.g4*
a5fab115c8973680f13274113ba1d9c1fe5708b00805a06644c7ce717c42ff19  STIXPattern.g4.20
b6429e8fed902133d2409d86c906b0c9dbaa4a54536023997ee73b460876b228  STIXPattern.g4.21
@vEpiphyte vEpiphyte marked this pull request as ready for review December 26, 2023 17:16
@vEpiphyte vEpiphyte changed the title Feat rebuild bindings Feat rebuild ANTLR bindings Dec 26, 2023
@vEpiphyte
Copy link
Author

@clenk @chisholm Can this be reviewed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be flexible with antlr version?
1 participant