-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report txt: fix printing of non-ascii details #844
Conversation
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
To launch regression testing public members of oamg organization can leave the following comment:
Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra. |
/rerun |
Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/6516691 |
Testing Farm request for RHEL-8.6-rhui/6513877;6516691 regression testing has been created. |
Testing Farm request for RHEL-7.9-rhui/6513877;6516691 regression testing has been created. |
Previous commit introduced couple of issues regarding details of reports that could lead to situations like: * remediation instructions has not been printed when non-ascii characters have been present * possible unwanted empty line when remediation has been specified but relative symlinks hasn't * if the URL title contained non-ascii character, it has been broken too (on py2) This should handle all mentioned problems when generating the txt file.
b89d92b
to
0809701
Compare
@oamg/developers tested manual on RHEL 7 & RHEL 8:
(yes, these invalid commands etc is the change I wanted, so the output looks like it should) |
Note there are no any unit-tests for this and I am skipping to add them now to unblock upstream testing of upgrades. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- - remediation gets printed even with non-ascii characters
- - unwanted empty line is no longer present when external links aren't specified
- - link with non-ascii characters gets printed just fine
Tested on RHEL8 and RHEL7 as follows:
Risk Factor: high (inhibitor)
Title: Local repository detected
Summary: The following local repository has been found: my-repo (their baseurl starts with file:///). Currently leapp does not support this option.
Related links:
- Customizing your Red Hat Enterprise Linux in-place upgrade ľščťžýáíéôúäň: ľščťžýáíéôúäň https://red.ht/ipu-customisation-repos-known-issues
Remediation: [hint] By using Apache HTTP Server you can expose your local repository via http. See the linked article for details. ľščťžýáíéôúäň
Key: 3450b32bfad8e1837b73b18e56c556d1052d5e4b
----------------------------------------
Risk Factor: high
Title: Remote root logins globally allowed using password
Summary: RHEL9 no longer allows remote root logins, but the server configuration explicitly overrides this default. The configuration file will not be updated and root is still going to be allowed to login with password. This is not recommended and considered as a security risk.
Remediation: [hint] If you depend on remote root logins using passwords, consider setting up a different user for remote administration. Otherwise you can ignore this message.
Key: e738f78bc8f3a84411a4210e3b609057139d1855
Previous commit introduced couple of issues regarding details of reports that could lead to situations like:
This should handle all mentioned problems when generating the txt file.