Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For headless VMs, DisplayType does not need to be checked. Otherwise, we will have problems while creating clones. #987

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

For headless VMs, DisplayType does not need to be checked. Otherwise, we will have problems while creating clones. #987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,6 +801,10 @@ public ValidationResult isOsTypeSupported(int osId, ArchitectureType architectur
*/
public ValidationResult isGraphicsAndDisplaySupported
(int osId, Collection<GraphicsType> graphics, DisplayType displayType, BiosType biosType, Version clusterVersion) {
// When we have no any display for vm then we don't have to check compatibility of display-graphics for selected OS
if (displayType == DisplayType.none) {
return ValidationResult.VALID;
}
if (!vmValidationUtils.isGraphicsAndDisplaySupported(osId, clusterVersion, graphics, displayType)) {
return new ValidationResult(
EngineMessage.ACTION_TYPE_FAILED_ILLEGAL_VM_DISPLAY_TYPE_IS_NOT_SUPPORTED_BY_OS);
Expand Down