Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force LC_ALL=C before running df -l command on pki-enroll-request #891

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

nkovacne
Copy link
Contributor

Changes introduced with this PR

  • pki-enroll-request.sh checks if the CA file is stored on a local filesystem. However, the 'df' command output depends on the local system language, thus output may vary. With this patch LANG=C is forced just before the 'df' command is run.

Are you the owner of the code you are sending in, or do you have permission of the owner?

Yes.

@nkovacne nkovacne changed the title Force LANG=C before running df -l command on pki-enroll-request Force LC_ALL=C before running df -l command on pki-enroll-request Nov 14, 2023
@didib
Copy link
Member

didib commented Nov 14, 2023

LGTM. Please handle the DCO failure - add a 'Signed-off-by:' line to your commits. And perhaps squash to a single commit.

@nkovacne nkovacne force-pushed the force-lang-c-pki-enroll-request branch from fef30a9 to 642791a Compare November 15, 2023 08:58
@nkovacne
Copy link
Contributor Author

LGTM. Please handle the DCO failure - add a 'Signed-off-by:' line to your commits. And perhaps squash to a single commit.

Removed the useless commit, and added the Signed-off-by line to the rebased commit.

@didib
Copy link
Member

didib commented Nov 15, 2023

Sorry, github insists on using the same "real name" in both the "Author" (and perhaps Commit) fields and in the "Signed-off-by" line. For former you have "Nicolás Kovac Neumann" but for latter you dropped "Neumann". See:

https://github.com/oVirt/ovirt-engine/pull/891/checks?check_run_id=18697876068

Please fix, thanks...

@nkovacne nkovacne force-pushed the force-lang-c-pki-enroll-request branch from 642791a to fe245b5 Compare November 15, 2023 09:25
@nkovacne nkovacne requested a review from didib November 15, 2023 09:34
@didib didib merged commit d48b5f1 into oVirt:master Nov 15, 2023
3 checks passed
@didib
Copy link
Member

didib commented Nov 15, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants