-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
engine: Add amt_ws fence agent support #810
Conversation
@mmartinv I'm targeting this for oVirt 4.6.0, if there's some urgency to get it earlier please let me know. |
/ost |
33ce083
to
6d6cd07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but better have more eyes looking on it and approving the PR.
I assume it was tested by you? :) If so, I believe adding a verified
label together with a short description of the testing scenario(s) is a good idea to increase reviewer's / code owner's confidence.
6d6cd07
to
ea0c3d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review @ahadas comments
ea0c3d2
to
3b9e7d1
Compare
fb7d556
to
d431cc3
Compare
d431cc3
to
4e1d2d5
Compare
Support Intel® Active Management Technology (Intel® AMT) for host power management. Signed-off-by: Miguel Martín <[email protected]>
4e1d2d5
to
1876331
Compare
Signed-off-by: Arik Hadas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmartinv I've changed the line that updates VdsFenceType to apply the addition of amt_ws also to cluster levels 4.4-4.7, please double check me. if that part is fine then we can merge this PR
got confirmation from @mmartinv |
Support Intel® Active Management Technology (Intel® AMT) for host power management.
Signed-off-by: Miguel Martín [email protected]