Bypass VM login attempt if SSO is not configured

Similar issues: - https://access.redhat.com/solutions/6982921 - https://bugzilla.redhat.com/show_bug.cgi?id=1391146 Signed-off-by: Denis Kvist <[email protected]>
oVirt · Dec 19, 2024 · 78b61df · 78b61df
1 parent 89b2cd1
commit 78b61df
Showing 1 changed file with 14 additions and 10 deletions.
diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogonCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogonCommand.java
@@ -49,15 +49,19 @@ protected void perform() {
         final DbUser currentUser = getCurrentUser();
         final String password = SsoUtils.getPassword(
                 sessionDataContainer.getSsoAccessToken(getParameters().getSessionId()));
-        final String domainController = currentUser != null ? currentUser.getDomain() : "";
-        final boolean sentToVM = runVdsCommand(
-                VDSCommandType.VmLogon,
-                new VmLogonVDSCommandParameters(
-                        getVdsId(),
-                        getVm().getId(),
-                        domainController,
-                        getUserName(),
-                        password)).getSucceeded();
-        setSucceeded(sentToVM);
+        if (password == null) {
+            setSucceeded(true);
+        } else {
+            final String domainController = currentUser != null ? currentUser.getDomain() : "";
+            final boolean sentToVM = runVdsCommand(
+                    VDSCommandType.VmLogon,
+                    new VmLogonVDSCommandParameters(
+                            getVdsId(),
+                            getVm().getId(),
+                            domainController,
+                            getUserName(),
+                            password)).getSucceeded();
+            setSucceeded(sentToVM);
+        }
     }
 }