Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] feat: linux and windows cfg options #729

Merged
merged 43 commits into from
Dec 25, 2022
Merged

[wip] feat: linux and windows cfg options #729

merged 43 commits into from
Dec 25, 2022

Conversation

ayushmanchhabra
Copy link
Collaborator

@ayushmanchhabra ayushmanchhabra commented Dec 13, 2022 •
edited
Loading

Fixes: #695
Fixes: #699
Fixes: #706
Fixes: #727

Changes

  • Set defaults for remaining options
  • Rename nw executable to app.name and fallback to package.json's name
  • Add Linux desktop entry file properties as options
  • Add Windows config options to rcedit

@ayushmanchhabra
set defaults for remaining options
757b7d4
@ayushmanchhabra
link cfg docs
81545c5
@ayushmanchhabra
fix cache issue
aa190b1
@ayushmanchhabra
generate cjs on npm publish only
7620640
@ayushmanchhabra
add desktop entry options to app argument
ffb4e9e
@ayushmanchhabra
Merge branch 'main' of github.com:nwutils/nw-builder into feat-cfg-op…
f8c0cbc 
…tions
@ayushmanchhabra
format
9f36dea
@ayushmanchhabra
fix tests
e4649de
@ayushmanchhabra
cfg wip
e2cbc41
@ayushmanchhabra
add config options to rcedit
0f0caf0
@ayushmanchhabra
add links to docs in code comments
8f9b29b
@ayushmanchhabra
add win cfg options to nwbuild
8a90d4a
@ayushmanchhabra
add note about latest stable version
bf6921e
@ayushmanchhabra
actually fix test
05d80d8
@ayushmanchhabra
remove all undefined properties which implies they are optional
37f7020
@ayushmanchhabra
update option names to create parity with msdn docs
0c92ab4
@ayushmanchhabra
add windows demo to ci
cd178ea
@ayushmanchhabra
seperate demos into separate files
97a7195
@ayushmanchhabra
assert win bld fail on linux without wine
95ee59d
@ayushmanchhabra
revert ci
1c261fa
@ayushmanchhabra
Merge branch 'main' of github.com:nwutils/nw-builder into feat-cfg-op…
b4e999e 
…tions
@ayushmanchhabra
build cjs in ci
81e2e3f
@ayushmanchhabra
typo
3e6bfa2
@ayushmanchhabra ayushmanchhabra marked this pull request as ready for review December 23, 2022 00:08
@ayushmanchhabra ayushmanchhabra changed the title feat: cfg options feat: linux and windows cfg options Dec 23, 2022
@ayushmanchhabra ayushmanchhabra mentioned this pull request Dec 23, 2022
Closed
1 task
TheJaredWilcurt
TheJaredWilcurt reviewed Dec 23, 2022
View reviewed changes
src/nwbuild.js Outdated Show resolved Hide resolved
TheJaredWilcurt
TheJaredWilcurt reviewed Dec 23, 2022
View reviewed changes
src/util/parse.js Outdated Show resolved Hide resolved
TheJaredWilcurt
TheJaredWilcurt reviewed Dec 23, 2022
View reviewed changes
docs/index.md Outdated Show resolved Hide resolved
sysrage
sysrage requested changes Dec 23, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/bld/winCfg.js Outdated Show resolved Hide resolved
src/nwbuild.js Outdated Show resolved Hide resolved
src/nwbuild.js Outdated Show resolved Hide resolved
@ayushmanchhabra ayushmanchhabra mentioned this pull request Dec 23, 2022
Closed
3 tasks
@ayushmanchhabra ayushmanchhabra mentioned this pull request Dec 23, 2022
Merged
@ayushmanchhabra ayushmanchhabra enabled auto-merge (squash) December 24, 2022 00:13
@ayushmanchhabra ayushmanchhabra changed the title feat: linux and windows cfg options [wip] feat: linux and windows cfg options Dec 24, 2022
@ayushmanchhabra ayushmanchhabra enabled auto-merge (squash) December 25, 2022 06:16
@ayushmanchhabra ayushmanchhabra merged commit 92c4aba into main Dec 25, 2022
@ayushmanchhabra ayushmanchhabra deleted the feat-cfg-options branch December 25, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJaredWilcurt TheJaredWilcurt TheJaredWilcurt left review comments

@sysrage sysrage sysrage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ayushmanchhabra @sysrage @TheJaredWilcurt