Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the default engine behavior in internal applicative eval functions #41

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

joaopluigi
Copy link
Contributor

Context

Following a change #38 in how dependencies are provided, services importing Nodely (indirectly through nodely-helpers) began facing errors. This occurred because services were not explicitly providing promesa as a dependency, even if they were not using it.

The issue stemmed from Nodely's applicative engine eval functions, which would default to using the promesa engine if no engine was specified. This resulted in promesa being included as a required dependency.

Since applicative eval functions are intended for internal use only and are accessed through the API, which sets the core-async engine when no engine is provided, the decision was made to remove the behavior of having a default engine at applicative eval functions.

@aredington
Copy link
Collaborator

aredington commented Nov 14, 2024

Going from providing a 2-arity and a 3-arity to only providing a 3-arity signature is a breaking change: clients who called the 2-arity version get failed when they were supported in the past.

Could we make an applicative engine that didn't rely on promesa lib (or any other of our optional libs) and continued to support the 2-arity version?

@joaopluigi joaopluigi marked this pull request as draft November 14, 2024 19:05
@joaopluigi
Copy link
Contributor Author

Going from providing a 2-arity and a 3-arity to only providing a 3-arity signature is a breaking change: clients who called the 2-arity version get failed when they were supported in the past.

Could we make an applicative engine that didn't rely on promesa lib (or any other of our optional libs) and continued to support the 2-arity version?

I converted the PR to draft, so we can still work on that

@joaopluigi joaopluigi marked this pull request as ready for review November 18, 2024 12:05
@joaopluigi joaopluigi merged commit ce2598f into main Nov 18, 2024
5 checks passed
@joaopluigi joaopluigi deleted the rm-promesa-as-default-applicative-engine branch November 18, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants