[Hotfix] pin numpy<2 #720
Open
[Hotfix] pin numpy<2 #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we start converting numpy arrays to lists ? |
|
@sjoerd-bouma the notes from Uppsala say that you wanted to have a look if it is feasable to convert numpy arrays before serialization. Do you think you get around this any time soon? |
Probably not before November - if you want to have a look yourself before then feel free. |
|
November is fine with me |
|
Looks like it is past November now @sjoerd-bouma ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #695 for discussion
Currently,
.nurfiles generated with numpy 2.* cannot be read in using earlier versions of numpy. This means we cannot guarantee compatibility even between two instances of the same version of NuRadioMC. This PR avoids this issue by pinningnumpy<2; in order to switch to numpy 2.*, we will probably have to switch tonumpy>=2in some future release of NuRadioMC in order to maintain cross-compatibility for a fixed NuRadioMC versions.(This is a proposed hotfix release v2.2.2; if accepted, this should also be merged into
developafterwards)