Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(core): move esbuild to use tinyglobby #29453

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Dec 21, 2024

An alternative to #28037, switches the esbuild package to use tinyglobby instead of fast-glob.

This improves performance a fair chunk and reduces install complexity/size.

cc @benmccann @JamesHenry

@43081j 43081j requested a review from a team as a code owner December 21, 2024 11:40
@43081j 43081j requested a review from ndcunningham December 21, 2024 11:40
Copy link

vercel bot commented Dec 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 30, 2024 4:38pm

Copy link

nx-cloud bot commented Dec 21, 2024

View your CI Pipeline Execution ↗ for commit 3718c89.

Command Status Duration Result
nx run-many -t check-imports check-commit check... ❌ Failed 1m 15s View ↗
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 7m 28s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=8a841... ✅ Succeeded 25s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 24s View ↗
nx documentation --no-dte ✅ Succeeded 48s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-30 16:49:53 UTC

Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the eslint entry as usual to avoid regressions

An alternative to nrwl#28037, switches the esbuild package to use
`tinyglobby` instead of `fast-glob`.

This improves performance a fair chunk and reduces install
complexity/size.
@43081j 43081j requested a review from a team as a code owner December 30, 2024 16:36
@43081j 43081j requested a review from JamesHenry December 30, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants