Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): quick fix to support trailing commas when reading hoisted … #29436

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FrozenPandaz
Copy link
Collaborator

…versions

Current Behavior

Graph fails when there is a trailing comma in a package.json

Expected Behavior

Graph does not fail and works when there is a trailing comma in a package.json

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested review from meeroslav and a team as code owners December 19, 2024 22:11
Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 10:12pm

Copy link

nx-cloud bot commented Dec 19, 2024

View your CI Pipeline Execution ↗ for commit 80dca07.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ❌ Failed 36m 32s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 1s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx format:check --base=16c8b... ✅ Succeeded 18s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 18s View ↗
nx documentation --no-dte ✅ Succeeded 1m 4s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-19 22:52:55 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants