Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): support custom cors headers #29382

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aidant
Copy link

@aidant aidant commented Dec 16, 2024

Current Behavior

It is not possible to pass custom cors headers to the @nx/web:file-server executor despite http-server supporting it.

Expected Behavior

@nx/web:file-server should pass-through a string of custom cors headers to http-server.

Related Issue(s)

@aidant aidant requested review from a team as code owners December 16, 2024 22:33
@aidant aidant requested a review from leosvelperez December 16, 2024 22:33
Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Dec 16, 2024 10:41pm

Copy link

nx-cloud bot commented Dec 16, 2024

Your CI Pipeline Execution ↗ for commit 1637cbc is in progress ⏳

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 29m 36s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 7s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded <1s View ↗
nx-cloud record -- nx format:check --base=ee4de... ✅ Succeeded 26s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 25s View ↗
nx documentation --no-dte ✅ Succeeded 46s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-16 23:11:58 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant