Auth tokens arg hardening #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stigok
force-pushed
the
auth-tokens-arg-hardening
branch
from
9981774 to
22aa47f
Compare
stigok
force-pushed
the
auth-tokens-arg-hardening
branch
2 times, most recently
from
f332c60 to
f8ea97e
Compare
stigok
requested review from
djbuster,
siljekristensen and
arott
and removed request for
a team
Foxboron
approved these changes
Jan 12, 2024
Having authentication enabled without any valid credentials is probably not intended. Additionally, this would previously still attempt to watch the empty file path, printing errors on regular intervals.
The log messages printed when the auth token file has been reloaded and read is now the same whether the amount of tokens is 0 or if its >0. However, if it's 0, a warning level message will be printed instead of an info level.
stigok
force-pushed
the
auth-tokens-arg-hardening
branch
from
f8ea97e to
0d15e5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce chance of inadvertenly exposing a private registry.