Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for aws s3 store #147

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Add support for aws s3 store #147

merged 1 commit into from
Dec 20, 2023

Conversation

pguinard-public-com
Copy link
Contributor

Adds support for downloading from an AWS s3 store.

@pguinard-public-com pguinard-public-com requested a review from a team as a code owner December 15, 2023 20:57
@pguinard-public-com pguinard-public-com requested review from stigok, martinsolberg and arott and removed request for a team December 15, 2023 20:57
@pguinard-public-com pguinard-public-com mentioned this pull request Dec 15, 2023
Closed
stigok
stigok requested changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@stigok stigok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sharing this code with us! 🚀 The overall quality is very good, however, there are some issues I need to address before merging this in.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
cmd/terraform-registry/main.go Outdated Show resolved Hide resolved
pkg/store/s3/s3.go Outdated Show resolved Hide resolved
pkg/store/s3/s3.go Outdated Show resolved Hide resolved
pkg/store/s3/s3.go Show resolved Hide resolved
stigok
stigok requested changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@stigok stigok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Just have some minor issues left :)

pkg/store/s3/s3.go Outdated Show resolved Hide resolved
pkg/store/s3/s3.go Show resolved Hide resolved
cmd/terraform-registry/main.go Outdated Show resolved Hide resolved
cmd/terraform-registry/main.go Outdated Show resolved Hide resolved
@stigok stigok merged commit 3619ebe into nrkno:main Dec 20, 2023
6 of 7 checks passed
@stigok
Copy link
Collaborator

stigok commented Dec 20, 2023

Thank you very much for your contribution. It was great to see that we got this in! Well done 🚢

@stigok
Copy link
Collaborator

stigok commented Dec 20, 2023

https://github.com/nrkno/terraform-registry/releases/tag/v0.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigok stigok stigok requested changes

@martinsolberg martinsolberg Awaiting requested review from martinsolberg martinsolberg is a code owner automatically assigned from nrkno/iac-admins

@arott arott Awaiting requested review from arott arott is a code owner automatically assigned from nrkno/iac-admins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pguinard-public-com @stigok