Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: port assert test to zephyr unit tests #650

Merged
merged 1 commit into from
Dec 2, 2024
Merged

tests: port assert test to zephyr unit tests #650

merged 1 commit into from
Dec 2, 2024

Conversation

ktaborowski
Copy link
Contributor

@ktaborowski ktaborowski commented Dec 2, 2024 •
edited
Loading

Assert tests to use zephyr unit testing framework. It fixes false negative result when the posix board was used.

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: main

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: master

Description

JIRA ticket:

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

@github-actions github-actions bot added source PR changing src files tests labels Dec 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

Sample diff used total

Memory usage did not change for any of the samples.

ktaborowski
ktaborowski commented Dec 2, 2024
View reviewed changes
tests/unit_tests/pal_assert/CMakeLists.txt
project(sidewalk_test_assert)

set(SIDEWALK_BASE $ENV{ZEPHYR_BASE}/../sidewalk)
# Workaround on build system not able to find this definition (in kernel.h)
add_definitions(-DARCH_STACK_PTR_ALIGN=8)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's some unit_tsting platform issue, not sure how to fix properly

@ktaborowski ktaborowski mentioned this pull request Dec 2, 2024
Merged
5 tasks
@ktaborowski
tests: port assert test to zephyr unit tests
2effa41 
Assert tests to use zephyr unit testing framework.
It fixes false negative result when the posix board was used.

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski ktaborowski merged commit 5308f19 into nrfconnect:main Dec 2, 2024
41 of 42 checks passed
@ktaborowski ktaborowski deleted the assert_test_fix branch December 4, 2024 10:04
@ktaborowski ktaborowski mentioned this pull request Dec 4, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@totyz totyz totyz approved these changes

@RobertGalatNordic RobertGalatNordic Awaiting requested review from RobertGalatNordic

Assignees
No one assigned
Labels
source PR changing src files tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktaborowski @totyz