Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MPSL and SoftDevice Controller #1590

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update MPSL and SoftDevice Controller #1590

wants to merge 2 commits into from

Conversation

NordicBuilder
Copy link
Contributor

@olivier-le-sage
mpsl: rev f373be939c1fa14caafcc8dbbd113869e8fdf273
e743f55 
CHANGELOG.rst contains the list of changes.

Signed-off-by: Olivier Lesage <[email protected]>
@olivier-le-sage
softdevice_controller: rev f373be939c1fa14caafcc8dbbd113869e8fdf273
e6c279d 
CHANGELOG.rst contains the list of changes.

Signed-off-by: Olivier Lesage <[email protected]>
@NordicBuilder NordicBuilder requested a review from a team as a code owner November 26, 2024 18:04
@NordicBuilder NordicBuilder mentioned this pull request Nov 26, 2024
Open
@rugeGerritsen
Copy link
Contributor

#1582 already contains an updated lib. Needs to be merged together to avoid breaking main

@rugeGerritsen rugeGerritsen added the DNM Do not merge label Nov 27, 2024
@olivier-le-sage
Copy link
Contributor

olivier-le-sage commented Nov 27, 2024 •
edited
Loading

#1582 already contains an updated lib. Needs to be merged together to avoid breaking main

this PR doesn't include Piotr's changes, and CI did run successfully. What exactly is it going to break?

@rugeGerritsen
Copy link
Contributor

It is going to delay nrfconnect/sdk-nrf#18981 which we want to avoid as this PR blocks other things

@olivier-le-sage
Copy link
Contributor

It is going to delay nrfconnect/sdk-nrf#18981 which we want to avoid as this PR blocks other things

so it's not breaking main.

@olivier-le-sage
Copy link
Contributor

the point of this PR is to fix the nightly:

just leaving this here in case anyone questions whether I tried to address the failures ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexstanoev-nordic alexstanoev-nordic alexstanoev-nordic approved these changes

@olivier-le-sage olivier-le-sage olivier-le-sage approved these changes

Assignees
No one assigned
Labels
DNM Do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NordicBuilder @rugeGerritsen @olivier-le-sage @alexstanoev-nordic