Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: lte_link_control: fix %NCELLMEAS notification parsing #19668

Merged

Conversation

tokangas
Copy link
Contributor

Added handling for %NCELLMEAS notification with status 2 (measurement interrupted), but no cells.

NRF91-2269

@tokangas tokangas requested a review from hiltunent December 20, 2024 08:10
@tokangas tokangas requested review from trantanen, jhirsi and a team as code owners December 20, 2024 08:10
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Dec 20, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 20, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: 627a7e35a640c948b68e53aadd8fb0ad2891f628

more details

sdk-nrf:

PR head: 627a7e35a640c948b68e53aadd8fb0ad2891f628
merge base: d9500b94b05c776294fda96ebb0baaedb553a47e
target head (main): d9500b94b05c776294fda96ebb0baaedb553a47e
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (3)
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
lib
│  ├── lte_link_control
│  │  ├── modules
│  │  │  │ ncellmeas.c
tests
│  ├── lib
│  │  ├── lte_lc_api
│  │  │  ├── src
│  │  │  │  │ lte_lc_api_test.c

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 363
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf-iot_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
    • ✅ test-fw-nrfconnect-nrf-iot_positioning
    • ⚠️ test-fw-nrfconnect-fw-update
    • ⚠️ test-fw-nrfconnect-nrf-iot_cloud
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@tokangas tokangas force-pushed the lte_lc_ncellmeas_interrupted_no_cells_fix branch from 7938f77 to e783576 Compare December 20, 2024 09:53
@tokangas tokangas requested a review from a team as a code owner December 20, 2024 09:53
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Dec 20, 2024
@tokangas tokangas force-pushed the lte_lc_ncellmeas_interrupted_no_cells_fix branch from e783576 to 21af9ad Compare December 20, 2024 09:57
@tokangas tokangas requested a review from a team as a code owner December 20, 2024 09:57
@tokangas
Copy link
Contributor Author

Something funny happened during rebase, the content is correct, but the commit message not. I'll fix it.

@tokangas tokangas force-pushed the lte_lc_ncellmeas_interrupted_no_cells_fix branch 2 times, most recently from e32b34b to 2af8199 Compare December 20, 2024 10:10
@tokangas tokangas removed the request for review from a team December 20, 2024 10:32
Added handling for %NCELLMEAS notification with status 2 (measurement
interrupted), but no cells.

NRF91-2269

Signed-off-by: Tommi Kangas <[email protected]>
@tokangas tokangas force-pushed the lte_lc_ncellmeas_interrupted_no_cells_fix branch from 2af8199 to 627a7e3 Compare December 20, 2024 10:53
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@rlubos rlubos merged commit 64064df into nrfconnect:main Dec 20, 2024
13 checks passed
@tokangas tokangas deleted the lte_lc_ncellmeas_interrupted_no_cells_fix branch December 20, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants