Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix the known issues filter script #19664

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

doc: fix the known issues filter script #19664

wants to merge 1 commit into from

Conversation

b-gent
Copy link
Contributor

@b-gent b-gent commented Dec 19, 2024

Update the script so it can work for v2.9.0-nRF54H20-rc1.

@b-gent b-gent requested a review from umapraseeda December 19, 2024 16:32
@b-gent b-gent requested a review from a team as a code owner December 19, 2024 16:32
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Dec 19, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 19, 2024 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: 743f319c60cf6deb9f659f75fea4a158e2638fcf

more details

sdk-nrf:

PR head: 743f319c60cf6deb9f659f75fea4a158e2638fcf
merge base: 4da34da64cf4229e5edc138457a5f7600b851fe3
target head (main): 84ec4da2bfb18ecc3a6adffb4ae67cb520634e04
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1) 
doc
│  ├── _extensions
│  │  ├── static
│  │  │  │ page_filter.mjs

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@b-gent b-gent added the DNM label Dec 19, 2024
@umapraseeda umapraseeda requested a review from gmarull December 19, 2024 17:06
@b-gent
doc: fix the known issues filter script
743f319 
Update the script so it can work for v2.9.0-nRF54H20-rc1.

Signed-off-by: Bartosz Gentkowski <[email protected]>
@b-gent b-gent force-pushed the fix_known_issues_script branch from 3ee1c2a to 743f319 Compare December 19, 2024 17:12
@umapraseeda
Copy link
Contributor

umapraseeda commented Dec 20, 2024 •
edited
Loading

Any way to test this before approval/merge, @gmarull ?

gmarull
gmarull reviewed Dec 20, 2024
View reviewed changes
doc/_extensions/static/page_filter.mjs
spanTag.setAttribute("version", className);
spanTag.classList.add("versiontag");
filterName = className.replace(/v(\d+)-(\d+)-(\d+)/i, 'v$1.$2.$3');
spanTag.setAttribute("filter", className);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff due to extra spaces being added?

gmarull
gmarull reviewed Dec 20, 2024
View reviewed changes
doc/_extensions/static/page_filter.mjs
spanTag.setAttribute("version", className);
spanTag.classList.add("versiontag");
// Updated replace method to handle additional segments after vX-X-X
filterName = className.replace(/v(\d+)-(\d+)-(\d+)(-.*)?/, (match, p1, p2, p3, p4) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this regex be used everywhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarull gmarull gmarull left review comments

@umapraseeda umapraseeda Awaiting requested review from umapraseeda

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@b-gent @NordicBuilder @umapraseeda @gmarull