samples: wifi: radio_test: Add a single domain combo radio test #19203

krish2718 · 2024-12-02T20:38:32Z

With the introduction of 54L15 SoC where the complete BLE stack runs on the CPUAPP itself, reorg the radio test directories based on domains. Single domain radio test is primarily for 54L15 (and other similar SoCs) which basically combines Wi-Fi and Peripheral radio test samples in to one.

test-sdk-wifi: sdk-nrf-pr-19203

NordicBuilder · 2024-12-02T20:39:28Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 10

Inputs:

Sources:

sdk-nrf: PR head: b96cfbf958a613c45ab9bca7c9f857ac0c0015ca

more details

sdk-nrf:

PR head: b96cfbf958a613c45ab9bca7c9f857ac0c0015ca
merge base: 66b211a8e682d80c49bdb092247a5e50acc8db89
target head (main): 66b211a8e682d80c49bdb092247a5e50acc8db89
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (31)

CODEOWNERS
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
│  │  ├── samples
│  │  │  ├── wifi.rst
│  │  │  ├── wifi_provisioning.rst
│  │  │  │ wifi_radiotest.rst
samples
│  ├── bluetooth
│  │  ├── throughput
│  │  │  ├── src
│  │  │  │  │ cmds.c
│  ├── cellular
│  │  ├── modem_shell
│  │  │  ├── src
│  │  │  │  ├── link
│  │  │  │  │  │ link_settings.c
│  ├── peripheral
│  │  ├── radio_test
│  │  │  ├── src
│  │  │  │  │ radio_cmd.c
│  ├── wifi
│  │  ├── radio_test
│  │  │  ├── multi_domain
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── Kconfig.sysbuild
│  │  │  │  ├── README.rst
│  │  │  │  ├── boards
│  │  │  │  │  │ thingy91x_nrf9151_ns.overlay
│  │  │  │  ├── ficr.rst
│  │  │  │  ├── inc
│  │  │  │  │  │ nrf_wifi_radio_test_shell.h
│  │  │  │  ├── prj.conf
│  │  │  │  ├── radio_test_subcommands.rst
│  │  │  │  ├── sample.yaml
│  │  │  │  ├── sample_description.rst
│  │  │  │  ├── src
│  │  │  │  │  ├── ficr_prog.c
│  │  │  │  │  ├── ficr_prog.h
│  │  │  │  │  ├── nrf_wifi_radio_ficr_shell.c
│  │  │  │  │  ├── nrf_wifi_radio_test_main.c
│  │  │  │  │  │ nrf_wifi_radio_test_shell.c
│  │  │  │  │ sysbuild.conf
│  │  │  ├── single_domain
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── Kconfig
│  │  │  │  ├── README.rst
│  │  │  │  ├── boards
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  ├── prj.conf
│  │  │  │  ├── sample.yaml
│  │  │  │  │ sysbuild.conf

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 797
❌ Integration tests
- ❌ test-fw-nrfconnect-ble_samples
- ✅ test-fw-nrfconnect-nrf-iot_samples
- ✅ test-fw-nrfconnect-nrf-iot_mosh
- ✅ test-sdk-wifi

Disabled integration tests

- desktop52_verification
- doc-internal
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-chip
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_nrf_provisioning
- test-fw-nrfconnect-nrf-iot_positioning
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-ps
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread
- test-fw-nrfconnect-zigbee
- test-low-level
- test-sdk-audio
- test-sdk-dfu
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-sidewalk
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

krish2718 · 2024-12-02T20:39:46Z

Need to work on the doc changes a bit and also haven't done any testing, hence leaving it in the draft state. Wanted to get an opinion on the approach before I invest any time.

krish2718 · 2024-12-16T16:50:51Z

I haven't received any objections on the approach, so, opening up for review.

NordicBuilder · 2024-12-17T10:36:09Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

richabp

Initial review.
Please add a Changelog entry.

samples/wifi/radio_test/multi_domain/README.rst

samples/wifi/radio_test/single_domain/Kconfig

samples/wifi/radio_test/single_domain/README.rst

samples/wifi/radio_test/single_domain/Kconfig

samples/wifi/radio_test/single_domain/README.rst

samples/wifi/radio_test/single_domain/boards/nrf54l15pdk_nrf54l15_cpuapp.conf

samples/wifi/radio_test/single_domain/README.rst

richabp

Approving with minor nits.

samples/wifi/radio_test/single_domain/README.rst

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

samples/wifi/radio_test/single_domain/src/ficr_prog.c

nordicjm · 2024-12-23T07:33:18Z

samples/wifi/radio_test/single_domain/src/ficr_prog.c

+						(REGION_PROTECT+3) << 2, write_val[0]);
+		break;
+	case QSPI_KEY:
+		mask_val = QSPI_KEY_FLAG_MASK;


For line#244?

With the introduction of 54L15 SoC where the complete BLE stack runs on the CPUAPP itself, reorg the radio test directories based on domains. Single domain radio test is primarily for 54L15 (and other similar SoCs) which basically combines Wi-Fi and Peripheral radio test samples in to one. Signed-off-by: Chaitanya Tata <[email protected]>

Found by compliance check. Signed-off-by: Chaitanya Tata <[email protected]>

Entry for Wi-Fi radio test changed. Signed-off-by: Chaitanya Tata <[email protected]>

Fix review comments: * Formatting * Styling * nRF Coding standards Signed-off-by: Chaitanya Tata <[email protected]>

krish2718 added this to the 2.9.0 milestone Dec 2, 2024

github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Dec 2, 2024

krish2718 requested review from prsi98, srkanordic and kspraveeen December 2, 2024 20:38

krish2718 removed this from the 2.9.0 milestone Dec 4, 2024

krish2718 marked this pull request as ready for review December 16, 2024 16:50

krish2718 requested review from a team, bama-nordic and sachinthegreen as code owners December 16, 2024 16:50

krish2718 force-pushed the add_54l_radio_test_combo branch from 90a3f4b to 1ba60e9 Compare December 16, 2024 16:50

krish2718 requested a review from richabp December 16, 2024 16:50

krish2718 force-pushed the add_54l_radio_test_combo branch from 1ba60e9 to 7edda92 Compare December 16, 2024 18:33

krish2718 requested review from a team, trantanen, jhirsi and tokangas as code owners December 16, 2024 18:33

krish2718 force-pushed the add_54l_radio_test_combo branch from 7edda92 to d9af837 Compare December 16, 2024 19:54

trantanen approved these changes Dec 17, 2024

View reviewed changes

tokangas approved these changes Dec 17, 2024

View reviewed changes

krish2718 force-pushed the add_54l_radio_test_combo branch from d9af837 to 4e36351 Compare December 17, 2024 10:18

krish2718 requested a review from a team as a code owner December 17, 2024 10:18

krish2718 force-pushed the add_54l_radio_test_combo branch from 4e36351 to a3dc392 Compare December 17, 2024 19:11

github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Dec 17, 2024

sachinthegreen approved these changes Dec 19, 2024

View reviewed changes

bama-nordic approved these changes Dec 19, 2024

View reviewed changes

richabp requested changes Dec 19, 2024

View reviewed changes

richabp reviewed Dec 19, 2024

View reviewed changes

samples/wifi/radio_test/single_domain/README.rst Outdated Show resolved Hide resolved

krish2718 force-pushed the add_54l_radio_test_combo branch from a3dc392 to 0a9c81a Compare December 20, 2024 15:00

krish2718 requested a review from a team as a code owner December 20, 2024 15:00

krish2718 requested a review from richabp December 20, 2024 15:15

richabp approved these changes Dec 20, 2024

View reviewed changes

samples/wifi/radio_test/single_domain/README.rst Outdated Show resolved Hide resolved

richabp requested changes Dec 20, 2024

View reviewed changes

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst Outdated Show resolved Hide resolved

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst Outdated Show resolved Hide resolved

krish2718 force-pushed the add_54l_radio_test_combo branch from 0a9c81a to 4a57643 Compare December 21, 2024 07:20

krish2718 requested a review from richabp December 21, 2024 07:29

richabp approved these changes Dec 21, 2024

View reviewed changes

nordicjm reviewed Dec 23, 2024

View reviewed changes

krish2718 added 4 commits December 23, 2024 22:57

treewide: Fix typo

0467990

Found by compliance check. Signed-off-by: Chaitanya Tata <[email protected]>

doc: changelog: Add Wi-Fi radio test changes

cd8d117

Entry for Wi-Fi radio test changed. Signed-off-by: Chaitanya Tata <[email protected]>

samples: wifi: radio_test: Fix review comments

b96cfbf

Fix review comments: * Formatting * Styling * nRF Coding standards Signed-off-by: Chaitanya Tata <[email protected]>

krish2718 force-pushed the add_54l_radio_test_combo branch from 4a57643 to b96cfbf Compare December 23, 2024 17:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

samples: wifi: radio_test: Add a single domain combo radio test #19203

samples: wifi: radio_test: Add a single domain combo radio test #19203

krish2718 commented Dec 2, 2024 •

edited

Loading

NordicBuilder commented Dec 2, 2024 •

edited

Loading

krish2718 commented Dec 2, 2024

krish2718 commented Dec 16, 2024

NordicBuilder commented Dec 17, 2024

richabp left a comment

richabp left a comment •

edited

Loading

nordicjm Dec 23, 2024

krish2718 Dec 23, 2024

samples: wifi: radio_test: Add a single domain combo radio test #19203

Are you sure you want to change the base?

samples: wifi: radio_test: Add a single domain combo radio test #19203

Conversation

krish2718 commented Dec 2, 2024 • edited Loading

NordicBuilder commented Dec 2, 2024 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

krish2718 commented Dec 2, 2024

krish2718 commented Dec 16, 2024

NordicBuilder commented Dec 17, 2024

richabp left a comment

Choose a reason for hiding this comment

richabp left a comment • edited Loading

Choose a reason for hiding this comment

nordicjm Dec 23, 2024

Choose a reason for hiding this comment

krish2718 Dec 23, 2024

Choose a reason for hiding this comment

krish2718 commented Dec 2, 2024 •

edited

Loading

NordicBuilder commented Dec 2, 2024 •

edited

Loading

richabp left a comment •

edited

Loading