Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wifi: Fix memleak in regulatory processing #18789

Closed
wants to merge 2 commits into from
Closed

wifi: Fix memleak in regulatory processing #18789

wants to merge 2 commits into from

Conversation

krish2718
Copy link
Contributor

Fixes a leak in regulatory processing.

@krish2718
manifest: sdk-nrfxlib: Pull fix for regulatory memleak
471d6a4 
Pull support to add a flag to know if a regulatory event is solicited or
not.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
drivers: wifi: Fix memory leak in regulatory processing
fe231ef 
During Wi-Fi connection UMAC sends an unsolicited regulatory change
event but the driver code always assumes that this event is solicited
hence doesn't free the memory for the event.

Fix this by dropping the unsolicited event as it's not supported yet.

Signed-off-by: Chaitanya Tata <[email protected]>
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Nov 10, 2024
@NordicBuilder
Copy link
Contributor

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
nrfxlib nrfconnect/sdk-nrfxlib@4309051 (v2.7-branch) nrfconnect/sdk-nrfxlib#1568 nrfconnect/sdk-nrfxlib#1568/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-chip X
test-sdk-wifi X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

Memory footprint analysis revealed the following potential issues

applications.nrf_desktop.zdebug[nrf52810dmouse/nrf52810]: RAM size increased by 908[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52833dongle/nrf52833]: RAM size increased by 1856[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52kbd/nrf52832]: RAM size increased by 2040[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52kbd/nrf52832]: ROM size increased by 3240[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_dongle[nrf52840dk/nrf52840]: RAM size increased by 1856[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease[nrf54l15pdk/nrf54l15/cpuapp]: RAM size increased by 1960[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease[nrf54l15pdk/nrf54l15/cpuapp]: ROM size increased by 5012[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_keyboard.usb_next[nrf52840dk/nrf52840]: RAM size increased by 2032[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_keyboard.usb_next[nrf52840dk/nrf52840]: ROM size increased by 2168[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_mcuboot_qspi[nrf52840dk/nrf52840]: RAM size increased by 2052[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_mcuboot_qspi[nrf52840dk/nrf52840]: ROM size increased by 2044[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease[nrf52820dongle/nrf52820]: RAM size increased by 1368[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease[nrf52840dongle/nrf52840]: RAM size increased by 1816[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease[nrf52840dongle/nrf52840]: ROM size increased by 3072[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease[nrf52kbd/nrf52832]: RAM size increased by 1988[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease[nrf52kbd/nrf52832]: ROM size increased by 4316[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease[nrf54h20dk/nrf54h20/cpuapp]: RAM size increased by 1426[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
sample.matter.template.release[nrf52840dk/nrf52840]: RAM size increased by 1555[B] in comparison to the main[3940f0e] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
applications.nrf_desktop.zdebug.usb_next[nrf52840gmouse/nrf52840]: RAM size increased by 2052[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug.usb_next[nrf52840gmouse/nrf52840]: ROM size increased by 1752[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_fast_pair.gmouse[nrf52840gmouse/nrf52840]: RAM size increased by 2173[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_fast_pair.gmouse[nrf52840gmouse/nrf52840]: ROM size increased by 2216[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_keyboard[nrf52840dk/nrf52840]: RAM size increased by 2032[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_keyboard[nrf52840dk/nrf52840]: ROM size increased by 2224[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
sample.matter.template.debug[nrf52840dk/nrf52840]: RAM size increased by 1067[B] in comparison to the main[3940f0e] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
applications.nrf_desktop.zdebug.usb_next[nrf52840dk/nrf52840]: RAM size increased by 2052[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug.usb_next[nrf52840dk/nrf52840]: ROM size increased by 1848[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52dmouse/nrf52832]: RAM size increased by 2076[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52dmouse/nrf52832]: ROM size increased by 1332[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_4llpmconn[nrf52840dongle/nrf52840]: RAM size increased by 1664[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_dongle.usb_next[nrf52840dk/nrf52840]: RAM size increased by 1856[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_wwcb[nrf52840dk/nrf52840]: RAM size increased by 2052[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_wwcb[nrf52840dk/nrf52840]: ROM size increased by 2064[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
sample.matter.template.release[nrf5340dk/nrf5340/cpuapp]: RAM size increased by 576[B] in comparison to the main[3940f0e] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
applications.nrf_desktop.zdebug[nrf52820dongle/nrf52820]: RAM size increased by 1408[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52840dk/nrf52840]: RAM size increased by 2052[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52840dk/nrf52840]: ROM size increased by 2064[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52840gmouse/nrf52840]: RAM size increased by 2052[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52840gmouse/nrf52840]: ROM size increased by 1968[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease[nrf52840gmouse/nrf52840]: RAM size increased by 2000[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease[nrf52840gmouse/nrf52840]: ROM size increased by 4264[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
sample.matter.template.release[nrf7002dk/nrf5340/cpuapp]: RAM size increased by 912[B] in comparison to the main[3940f0e] branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
applications.nrf_desktop.zdebug[nrf5340dk/nrf5340/cpuapp]: RAM size increased by 1340[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebugwithshell[nrf52840dk/nrf52840]: RAM size increased by 2108[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebugwithshell[nrf52840dk/nrf52840]: ROM size increased by 1792[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease_fast_pair.keyboard[nrf52kbd/nrf52832]: RAM size increased by 2107[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease_fast_pair.keyboard[nrf52kbd/nrf52832]: ROM size increased by 4478[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug.usb_next[nrf52840dongle/nrf52840]: RAM size increased by 1856[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52833dk/nrf52820]: RAM size increased by 1408[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52833dk/nrf52833]: RAM size increased by 1856[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52840dongle/nrf52840]: RAM size increased by 1856[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_nrf21540ek_multicore[nrf5340dk/nrf5340/cpuapp]: RAM size increased by 1340[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease[nrf5340dk/nrf5340/cpuapp]: RAM size increased by 1364[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_mcuboot_smp[nrf52840dk/nrf52840]: RAM size increased by 2052[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_mcuboot_smp[nrf52840dk/nrf52840]: ROM size increased by 1996[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_nrf21540ek[nrf52840dk/nrf52840]: RAM size increased by 2060[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_nrf21540ek[nrf52840dk/nrf52840]: ROM size increased by 2092[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease[nrf52833dk/nrf52820]: RAM size increased by 1368[B] in comparison to the main[3940f0e] branch. - link (cc: @MarekPieta)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-18789/1)

@github-actions GitHub Actions
Copy link

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Dec 17, 2024
@github-actions github-actions bot closed this Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachinthegreen sachinthegreen sachinthegreen approved these changes

@rado17 rado17 Awaiting requested review from rado17 rado17 is a code owner

@rlubos rlubos Awaiting requested review from rlubos rlubos is a code owner

@carlescufi carlescufi Awaiting requested review from carlescufi carlescufi is a code owner

@tejlmand tejlmand Awaiting requested review from tejlmand tejlmand is a code owner

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM manifest manifest-nrfxlib Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krish2718 @NordicBuilder @sachinthegreen