Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: matter: Reduce memory usage #18554

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

adigie
Copy link
Member

@adigie adigie commented Nov 5, 2024

  • Remove custom heap size from nRF54L15 configs.
  • Reduce Packet Buffer Pool size to 11.

@adigie adigie requested review from a team as code owners November 5, 2024 09:20
@CLAassistant
Copy link

CLAassistant commented Nov 5, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Nov 5, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 5, 2024

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
matter nrfconnect/sdk-connectedhomeip@20babbe nrfconnect/sdk-connectedhomeip@2340e0a (master) nrfconnect/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 5, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 12

Inputs:

Sources:

sdk-nrf: PR head: 419e7debee95e5a9bad70fdebc8c606d38e20d54
matter: PR head: 2340e0aad89bd415a3a1faa0af0da69169c8aa4a

more details

sdk-nrf:

PR head: 419e7debee95e5a9bad70fdebc8c606d38e20d54
merge base: 31d1fa50d22bae9559f3ee06303ca56823a79a3e
target head (main): 37fba0b31a04db7499cc9cc7c77f4e60a7b77117
Diff

matter:

PR head: 2340e0aad89bd415a3a1faa0af0da69169c8aa4a
merge base: 20babbe7904f55511c39f19cae2162f7b770f974
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (19)
doc
│  ├── nrf
│  │  ├── protocols
│  │  │  ├── matter
│  │  │  │  ├── getting_started
│  │  │  │  │  │ memory_optimization.rst
modules
│  ├── lib
│  │  ├── matter
│  │  │  ├── .github
│  │  │  │  ├── workflows
│  │  │  │  │  │ release_tools.yaml
│  │  │  ├── config
│  │  │  │  ├── nrfconnect
│  │  │  │  │  ├── chip-module
│  │  │  │  │  │  │ Kconfig
│  │  │  ├── src
│  │  │  │  ├── platform
│  │  │  │  │  ├── nrfconnect
│  │  │  │  │  │  │ SystemPlatformConfig.h
samples
│  ├── matter
│  │  ├── light_bulb
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ns.conf
│  │  ├── light_switch
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ns.conf
│  │  ├── lock
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ns.conf
│  │  ├── smoke_co_alarm
│  │  │  ├── boards
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  ├── template
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp_internal.conf
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ns.conf
│  │  ├── thermostat
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ns.conf
│  │  ├── window_covering
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ns.conf
west.yml

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 11
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-chip
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@adigie adigie force-pushed the optimize-memory-usage branch from 1c4929b to efa71d3 Compare November 5, 2024 09:24
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@adigie adigie force-pushed the optimize-memory-usage branch from efa71d3 to b5ba2cc Compare November 19, 2024 14:19
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@adigie adigie force-pushed the optimize-memory-usage branch from b5ba2cc to 68fbb87 Compare November 19, 2024 15:22
@adigie adigie requested a review from a team as a code owner November 19, 2024 15:22
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Nov 19, 2024
@adigie adigie force-pushed the optimize-memory-usage branch from 68fbb87 to 498ab89 Compare November 20, 2024 07:52
@wiba-nordic
Copy link
Contributor

I'll hold on approving for a bit since I'm also part of ncs-matter, so one of the guys can properly approve.

@adigie adigie added this to the 3.0.0 milestone Dec 4, 2024
@adigie adigie force-pushed the optimize-memory-usage branch 2 times, most recently from 6916b5b to 8b065e3 Compare December 13, 2024 07:50
@NordicBuilder NordicBuilder removed the DNM label Dec 13, 2024
@adigie adigie force-pushed the optimize-memory-usage branch from 8b065e3 to d69bf88 Compare December 13, 2024 07:53
@adigie
Copy link
Member Author

adigie commented Dec 13, 2024

@nrfconnect/ncs-code-owners Please review.

@adigie
Copy link
Member Author

adigie commented Dec 20, 2024

@nrfconnect/ncs-code-owners Could you take a look?

@ArekBalysNordic
Copy link
Contributor

@peknis could you please look at it? ncs-matter-doc code owner has been changed and we need a new approval.

@adigie adigie force-pushed the optimize-memory-usage branch 2 times, most recently from f293b62 to fe4fb5e Compare December 20, 2024 11:36
Use default heap size on nRF54L15.

Signed-off-by: Adrian Gielniewski <[email protected]>
* Add Kconfig for packet buffer pool size.
* Reduce packet buffer pool size to 11.
* Fix release tools workflow.

Signed-off-by: Adrian Gielniewski <[email protected]>
Mention `CONFIG_CHIP_SYSTEM_PACKETBUFFER_POOL_SIZE` Kconfig option.

Signed-off-by: Adrian Gielniewski <[email protected]>
@adigie
Copy link
Member Author

adigie commented Dec 20, 2024

@ArekBalysNordic we can merge this PR, as @peknis approved it and then I re-requested a review by mistake.

@ArekBalysNordic ArekBalysNordic merged commit 4e452f3 into nrfconnect:main Dec 20, 2024
13 checks passed
@adigie adigie deleted the optimize-memory-usage branch December 20, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval. manifest manifest-matter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants