-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: add thingy91x board #13379
boards: add thingy91x board #13379
Conversation
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
Note: We have to make sure to make a distinction between PCA20064 and PCA20065 (newer version that is planned to be the main release). |
PRs that need to be handled before this can be finished: |
}; | ||
}; | ||
|
||
/* Disable Zephyr driver for UART1. The nrfx driver is used for interfacing with UART1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is outdated. The UART trace backend now uses the Zephyr driver depending on the device tree chosen node for modem traces:
chosen {
nordic,modem-trace-uart = &uart1;
};
So it depends on if we want modem traces to be enabled by default or not. It might make sense to disable by default for battery usage, and use a snippet to enable when needed. But perhaps set the default directly in thingy91x_nrf9161_common.dts? Or does it need to differ between secure/non secure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to comment to make clear why this is disabled by default in non-secure.
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
ab6d4f4
to
0f37e44
Compare
I decided to remove MCUBoot serial recovery from the nrf91 image since we will ship with a debugger. |
the zephyr fork now only contains fromtree commits! Only need to update Zephyr (and add stuff to mcuboot) for basic support of the device now. |
3100e6b
to
aed69ea
Compare
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
25b1457
to
13e3259
Compare
rebased an squashed - ready from my point of view |
7005824
to
9741f56
Compare
touched up the headers to make sure license remarks are present and consistent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified by building and testing samples on both 9151 and 5340 chip.
This patch adds board files for the Thingy:91 X. Signed-off-by: Bernt Johan Damslora <[email protected]> Signed-off-by: Maximilian Deubel <[email protected]>
9741f56
to
afd2968
Compare
This patch adds board files for the Thingy:91 X.
The required changes to Zephyr and MCUBoot have been merged!
We're ready to go!