drivers: wifi: Move OS agnostic code to nrfxlib #12835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krish2718
requested review from
muraliThokala,
bama-nordic,
sachinthegreen,
udaynordic,
srkanordic,
rado17,
rlubos,
carlescufi and
tejlmand
as code owners
github-actions
bot
added
changelog-entry-required
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
github-actions
bot
added
the
doc-required
gmarull
reviewed
Oct 24, 2023
gmarull
approved these changes
Oct 24, 2023
|
Any ideas of CI failure for doc build?
@gmarull @carlescufi any ideas? |
|
@krish2718 can you try forcing non-parallel build? Add a temp commit doing something like this: diff --git a/.github/workflows/docbuild.yml b/.github/workflows/docbuild.yml
index 6f453075c..d16964c75 100644
--- a/.github/workflows/docbuild.yml
+++ b/.github/workflows/docbuild.yml
@@ -64,7 +64,7 @@ jobs:
- name: Build documentation
working-directory: ncs/nrf
run: |
- cmake -GNinja -Bdoc/_build -Sdoc
+ cmake -GNinja -Bdoc/_build -Sdoc -DSPHINXOPTS="-j 1 -W -T"
ninja -C doc/_build
- name: Prepare archive |
krish2718
force-pushed
the
move_osal
branch
2 times, most recently
from
808ae33 to
6a82960
Compare
looks like this is helping, so, should we make this by default at the cost of time? Or debug the issue? |
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
VivekUppunda
approved these changes
Oct 26, 2023
rado17
approved these changes
Oct 26, 2023
richabp
reviewed
Oct 26, 2023
github-actions
bot
removed
the
changelog-entry-required
sachinthegreen
approved these changes
Oct 27, 2023
krish2718
force-pushed
the
move_osal
branch
2 times, most recently
from
1dde8e7 to
e459705
Compare
krish2718
force-pushed
the
move_osal
branch
2 times, most recently
from
bea6333 to
1d5d17b
Compare
The OS agnostic code can be used by any OS, currently Zephyr and Linux are supported, so: * move to nrfxlib as nrf is only for Zephyr. * remove the Zephyr prefix and folder for the remaining files. * remove OSAL files from CODEOWNERS * Move nRF70 drivers docs to nrfxlib (this has only OS agnostic docs) Fixes SHEL-1763. Signed-off-by: Chaitanya Tata <[email protected]>
Add an entry for moving OS agnostic code to nrfxlib. Signed-off-by: Chaitanya Tata <[email protected]>
richabp
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.