Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Changes for Furious Check Box Issues In IE - furiousLegend.js & legend.js #2011

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gowrishankaran
Copy link

Hi Guys,

I fixed the Furious Legend Issues in IE Browser. Not tested in Safari. I hope it will work in safari also.

.property('innerHTML') - InnerHTML not working in IE. That's why path 'nv-box' and 'nv-check' elements are not rendering inside g 'nv-check-box' element.

So, I updated the code like below.

Current Code:

seriesEnter.append('g')
        .attr('class', 'nv-check-box')
        .property('innerHTML','<path d="M0.5,5 L22.5,5 L22.5,26.5 L0.5,26.5 L0.5,5 Z" class="nv-box"></path><path d="M5.5,12.8618467 L11.9185089,19.2803556 L31,0.198864511" class="nv-check"></path>')
        .attr('transform', 'translate(-10,-8)scale(0.5)');

Update Code:

var seriesFuriousBox = seriesEnter.append('g')
   .attr('class', 'nv-check-box')
   .attr('transform', 'translate(-10,-8)scale(0.5)');

   // For Box
   seriesFuriousBox.append('path')
   .attr('d','M0.5,5 L22.5,5 L22.5,26.5 L0.5,26.5 L0.5,5 Z')
   .attr('class','nv-box');
   
   // For Check
   seriesFuriousBox.append('path')
   .attr('d','M5.5,12.8618467 L11.9185089,19.2803556 L31,0.198864511')
   .attr('class','nv-check'); 

Thanks,
Gowri Shankar

@@ -63,10 +63,24 @@ nv.models.furiousLegend = function() {

seriesShape = series.select('rect');

seriesEnter.append('g')
// seriesEnter.append('g')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gowrishankaran why not just delete the old code? We have git for version control if we ever need to get it back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants