fix(api): headless service fetchNotifications should accept archived filter #7136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for novu-stg-vite-dashboard-poc pending review.Visit the deploys page to approve it
|
gruckion
changed the title
…epository-find-by-subscriber-channel
…epository-find-by-subscriber-channel
…epository-find-by-subscriber-channel
👷 Deploy request for dev-web-novu pending review.Visit the deploys page to approve it
|
👷 Deploy request for dashboard-v2-novu-staging pending review.Visit the deploys page to approve it
|
|
Can you review please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
The
fetchNotifications()withinheadless.service.tsuses the typeIStoreQueryfor the query. But this property does not havearchived: booleaneven though the backend message repositorygetFilterQueryForMessagedoes support it.Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer