Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: delta CRL #247

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

feat: delta CRL #247

wants to merge 25 commits into from

Conversation

JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Nov 26, 2024 •
edited
Loading

Feat:

  • added delta CRL support

Note: only support Freshest CRL from base CRL extension.
Resolves #228

@JeyJeyGao
feat: delta CRL
e34370f 
Signed-off-by: Junjie Gao <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.23810% with 9 lines in your changes missing coverage. Please review.

Project coverage is 92.25%. Comparing base (2cd55de) to head (dc3a62e).

Files with missing lines Patch % Lines
revocation/crl/fetcher.go 88.60% 6 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
+ Coverage   92.02%   92.25%   +0.23%     
==========================================
  Files          31       32       +1     
  Lines        2645     2801     +156     
==========================================
+ Hits         2434     2584     +150     
- Misses        161      165       +4     
- Partials       50       52       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeyJeyGao JeyJeyGao marked this pull request as ready for review November 28, 2024 09:07
@JeyJeyGao JeyJeyGao marked this pull request as draft December 2, 2024 07:20
@JeyJeyGao JeyJeyGao marked this pull request as ready for review December 9, 2024 05:46
shizhMSFT
shizhMSFT reviewed Dec 12, 2024
View reviewed changes
revocation/crl/fetcher.go Outdated Show resolved Hide resolved
revocation/crl/fetcher.go Outdated Show resolved Hide resolved
revocation/crl/fetcher.go Outdated Show resolved Hide resolved
revocation/internal/crl/crl.go Outdated Show resolved Hide resolved
revocation/internal/crl/crl.go Outdated Show resolved Hide resolved
revocation/internal/crl/crl.go Outdated Show resolved Hide resolved
revocation/internal/crl/crl.go Outdated Show resolved Hide resolved
revocation/internal/crl/crl.go Outdated Show resolved Hide resolved
revocation/internal/crl/crl.go Show resolved Hide resolved
revocation/internal/crl/crl.go Outdated Show resolved Hide resolved
@JeyJeyGao
fix: update
a9330e5 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: optimize Fetch
b2f2852 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: update
1239c5c 
Signed-off-by: Junjie Gao <[email protected]>
shizhMSFT
shizhMSFT requested changes Dec 13, 2024
View reviewed changes
revocation/crl/fetcher.go Outdated Show resolved Hide resolved
revocation/internal/crl/crl.go Outdated Show resolved Hide resolved
revocation/internal/crl/crl.go Outdated Show resolved Hide resolved
@JeyJeyGao JeyJeyGao requested a review from shizhMSFT December 16, 2024 05:46
@JeyJeyGao
fix: update
6becbe1 
Signed-off-by: Junjie Gao <[email protected]>
shizhMSFT
shizhMSFT previously approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Two-Hearts
Two-Hearts reviewed Dec 23, 2024
View reviewed changes
revocation/crl/fetcher.go Outdated Show resolved Hide resolved
revocation/internal/crl/crl.go Outdated Show resolved Hide resolved
revocation/internal/crl/crl.go Outdated Show resolved Hide resolved
revocation/internal/crl/crl.go Outdated Show resolved Hide resolved
@JeyJeyGao
fix: add license
52c48a8 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: simplify code
0e5b4d0 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: test
dc3a62e 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao JeyJeyGao requested a review from Two-Hearts December 24, 2024 02:26
Two-Hearts
Two-Hearts approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Two-Hearts Two-Hearts Two-Hearts approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@priteshbandi priteshbandi Awaiting requested review from priteshbandi priteshbandi is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delta CRL support
3 participants
@JeyJeyGao @shizhMSFT @Two-Hearts