-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerating testing certificates #1676
base: master
Are you sure you want to change the base?
Regenerating testing certificates #1676
Conversation
Signed-off-by: Stefan Bogoevski <[email protected]>
c9c7a6b
to
c98221f
Compare
@justincormack We are experiencing failing CI/CD jobs at our company because of this (some of the notary tests are failing), and would appreciate if someone could look into this pull request. Thanks! |
@justincormack @HuKeping @jonnystoten Is any of you able to take a look at this PR? Notary is unusable without updating the certificates.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Thanks @jonnystoten ! @justincormack I imagine this is ready to go to |
Hi @justincormack , @jonnystoten , @stefan-zh , |
Hi all, Doug Singer here -- DevSecOps Engineer for Modern Technology Solutions, INC. In the process of doing some R&D for our dept, I was investigating this project. Ran into the x509 expiration issue and found this thread. Looks like this PR may resolve the issue we're having, so I will keep an eye on it. Thank you, all. |
Can we help somehow? |
Hi @halamix2 thank you for responding. From our perspective, this is OBE at the moment. |
The test certificates expired and we need to regenerate them so that notary works in a local environment.
This is similar to previous pull request (#1594) .