Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

Fix SVGs import syntax #31

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Fix SVGs import syntax #31

merged 2 commits into from
Oct 24, 2023

Conversation

ATrogolo
Copy link
Contributor

What

I've appended to the SVG path the string "?react" as specified in the vite-plugin-svgr docs

Without this flag SVGs won't be imported as components unless changing the include options of the plugin with:

include: "**/*.svg",

because default is:

include: "**/*.svg?react",

@ATrogolo ATrogolo requested a review from a team as a code owner October 21, 2023 20:55
nowyDEV
nowyDEV approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@nowyDEV nowyDEV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@nowyDEV nowyDEV merged commit a282e7c into nordcloud:master Oct 24, 2023
4 of 5 checks passed
@ATrogolo ATrogolo deleted the patch-1 branch October 24, 2023 09:22
@ATrogolo
Copy link
Contributor Author

Damn!
I forgot to remove the Types definition src/custom.d.ts from docs/CRA_MIGRATION_GUIDE.md 😔
I'll submit a new PR by the end of the day

@nowyDEV
Copy link
Member

nowyDEV commented Oct 24, 2023

Damn! I forgot to remove the Types definition src/custom.d.ts from docs/CRA_MIGRATION_GUIDE.md 😔 I'll submit a new PR by the end of the day

Sure, no worries

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nowyDEV nowyDEV nowyDEV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ATrogolo @nowyDEV