remove fp plugin (#7)

nordcloud · Jun 30, 2022 · c5f93ac · c5f93ac
1 parent d823c52
commit c5f93ac
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 149 deletions.
diff --git a/mixins/cypress.js b/mixins/cypress.js
@@ -13,7 +13,6 @@ module.exports = {
         "promise/catch-or-return": "off",
         "promise/no-nesting": "off",
         "promise/always-return": "off",
-        "fp/no-loops": "off",
       },
     },
   ],

diff --git a/mixins/react.js b/mixins/react.js
@@ -30,18 +30,6 @@ module.exports = {
       ],
 
       rules: {
-        "fp/no-mutation": [
-          "warn",
-          {
-            commonjs: true,
-            exceptions: [
-              { object: "window", property: "location" },
-              // Usage with React refs
-              { property: "current" },
-            ],
-          },
-        ],
-
         // avoid false-positives for module bundlers resolution
         "import/no-unresolved": "off",
 
@@ -146,10 +134,6 @@ module.exports = {
 
         // eslint-plugin-testing-library
         "testing-library/prefer-screen-queries": "warn",
-
-        // eslint-plugin-fp
-        // for...of loops are useful for awaiting multiple testing library queries
-        "fp/no-loops": "off",
       },
     },
   ],

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@nordcloud/eslint-config-pat",
-  "version": "2.1.2",
+  "version": "3.0.0",
   "description": "Shareable ESLint config for PAT projects",
   "author": "Nordcloud Engineering",
   "license": "MIT",
@@ -54,7 +54,6 @@
     "@typescript-eslint/parser": "^4.22.0",
     "eslint-config-prettier": "^8.1.0",
     "eslint-plugin-cypress": "^2.11.2",
-    "eslint-plugin-fp": "^2.3.0",
     "eslint-plugin-import": "^2.25.3",
     "eslint-plugin-jest": "^24.3.4",
     "eslint-plugin-jest-dom": "^4.0.1",

diff --git a/profile/_common.js b/profile/_common.js
@@ -38,8 +38,6 @@ function buildRules(profile) {
     // Disable the parser by default
     parser: "",
 
-    plugins: ["fp"],
-
     // Manually authored .d.ts files are generally used to describe external APIs that are  not expected
     // to follow our coding conventions.  Linting those files tends to produce a lot of spurious suppressions,
     // so we simply ignore them.
@@ -74,7 +72,6 @@ function buildRules(profile) {
           "plugin:@typescript-eslint/eslint-recommended",
           "plugin:@typescript-eslint/recommended",
           "plugin:promise/recommended",
-          "plugin:fp/recommended",
           "plugin:import/errors",
           "plugin:import/warnings",
           "plugin:import/typescript",
@@ -104,29 +101,6 @@ function buildRules(profile) {
           "promise/catch-or-return": "off",
           "promise/always-return": "error",
 
-          // eslint-plugin-fp
-          "fp/no-unused-expression": "off",
-          "fp/no-rest-parameters": "off",
-          "fp/no-nil": "off",
-          "fp/no-throw": "off",
-          "fp/no-loops": "warn",
-          "fp/no-let": "warn",
-          "fp/no-mutating-methods": [
-            "warn",
-            {
-              ...(isWebAppProfile && { allowedObjects: ["history"] }),
-            },
-          ],
-          "fp/no-mutation": [
-            "warn",
-            {
-              commonjs: true,
-              exceptions: isWebAppProfile
-                ? [{ object: "window", property: "location" }]
-                : [],
-            },
-          ],
-
           // eslint-plugin-import
           "import/no-extraneous-dependencies": "off",
           "import/no-relative-parent-imports": "off",