Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate and remove awesome styled grid from main bundle #677

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Deprecate and remove awesome styled grid from main bundle #677

merged 2 commits into from
Oct 26, 2023

Conversation

nowyDEV
Copy link
Member

@nowyDEV nowyDEV commented Oct 26, 2023

What

This is a breaking change that addresses #676

  • Awesome Styled Grid Library is no longer appended to the main bundle and was removed from dependencies
  • Added deprecation note inside Grid story

Compatibility

  • Does this change maintain backward compatibility?

Screenshots

Before

After

@nowyDEV nowyDEV added bug Something isn't working dependencies Changes in npm packages labels Oct 26, 2023
@nowyDEV nowyDEV self-assigned this Oct 26, 2023
@nowyDEV nowyDEV requested a review from a team as a code owner October 26, 2023 10:30
@aws-amplify-eu-west-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-677.du3gff836giqw.amplifyapp.com

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nowyDEV nowyDEV merged commit 704ab7b into master Oct 26, 2023
8 checks passed
@nowyDEV nowyDEV deleted the remove-awesome-styled-grid branch October 26, 2023 11:56
@nowyDEV nowyDEV mentioned this pull request Oct 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janosio janosio janosio approved these changes

@ErnestasZaloga ErnestasZaloga Awaiting requested review from ErnestasZaloga ErnestasZaloga is a code owner automatically assigned from nordcloud/core-frontend-reviewers

@ievavizg ievavizg Awaiting requested review from ievavizg ievavizg is a code owner automatically assigned from nordcloud/core-frontend-reviewers

Assignees

@nowyDEV nowyDEV

Labels
bug Something isn't working dependencies Changes in npm packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowyDEV @janosio