Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add ts eval snapshots #56358

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

test: add ts eval snapshots #56358

wants to merge 3 commits into from
+104 −107

Conversation

marco-ippolito
Copy link
Member

Some light refactoring and printing error message from --eval with ts

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Dec 25, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.55%. Comparing base (ba59928) to head (be5e243).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #56358   +/-   ##
=======================================
  Coverage   88.54%   88.55%           
=======================================
  Files         657      657           
  Lines      190658   190639   -19     
  Branches    36591    36595    +4     
=======================================
- Hits       168821   168818    -3     
+ Misses      15015    15006    -9     
+ Partials     6822     6815    -7
Files with missing lines Coverage Δ
lib/internal/process/execution.js 95.46% <100.00%> (+0.42%) ⬆️

... and 26 files with indirect coverage changes

@marco-ippolito marco-ippolito added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. strip-types Issues or PRs related to strip-types support labels Dec 26, 2024
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 27, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 27, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64230/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64233/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64235/

@marco-ippolito
Copy link
Member Author

Its a real failure on windows arm64 😭😭😭😭😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. strip-types Issues or PRs related to strip-types support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marco-ippolito @nodejs-github-bot @jasnell @anonrig