module: use buffer.toString base64 #56315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
module
legendecas
force-pushed
the
module/forbid-btoa
branch
from
d80a7c5 to
b79fd6a
Compare
legendecas
changed the title
aduh95
reviewed
Dec 19, 2024
legendecas
force-pushed
the
module/forbid-btoa
branch
from
b79fd6a to
b041282
Compare
anonrig
reviewed
Dec 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56315 +/- ##
==========================================
+ Coverage 88.04% 88.54% +0.50%
==========================================
Files 657 657
Lines 190290 190297 +7
Branches 36245 36535 +290
==========================================
+ Hits 167536 168499 +963
+ Misses 15893 14979 -914
+ Partials 6861 6819 -42
|
`btoa` only supports latin-1 charset and produces invalid source mapping urls.
legendecas
force-pushed
the
module/forbid-btoa
branch
from
b041282 to
7572a08
Compare
anonrig
approved these changes
Dec 19, 2024
aduh95
approved these changes
Dec 19, 2024
Co-authored-by: Antoine du Hamel <[email protected]>
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
marco-ippolito
approved these changes
Dec 19, 2024
cjihrig
approved these changes
Dec 19, 2024
lpinca
approved these changes
Dec 19, 2024
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4fd5db4 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
btoaonly supports latin-1 charset and produces invalid source mapping urls.This also forbids usage of
btoainlib/without particular reasons.Refs: #56296