Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_runner,cli: mark test isolation as stable #56298

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 17, 2024

This commit stabilizes test isolation configuration in the test runner.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Dec 17, 2024
doc/api/cli.md Outdated Show resolved Hide resolved
@cjihrig cjihrig added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 17, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2024
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.54%. Comparing base (0d00511) to head (8e09ae6).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/node_options.cc 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56298      +/-   ##
==========================================
+ Coverage   88.04%   88.54%   +0.50%     
==========================================
  Files         657      657              
  Lines      190290   190296       +6     
  Branches    36245    36539     +294     
==========================================
+ Hits       167536   168497     +961     
+ Misses      15893    14987     -906     
+ Partials     6861     6812      -49     
Files with missing lines Coverage Δ
lib/internal/test_runner/utils.js 56.20% <100.00%> (ø)
src/node_options.cc 88.00% <66.66%> (+0.01%) ⬆️

... and 95 files with indirect coverage changes

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lhym

Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably keep --experimental-test-isolation around as an alias and remove it in the next major

This commit stabilizes test isolation configuration in the
test runner.
@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 18, 2024

We could probably keep --experimental-test-isolation around as an alias and remove it in the next major

Good idea. I have added an alias.

@cjihrig cjihrig added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 18, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 18, 2024
@nodejs-github-bot
Copy link
Collaborator

doc/api/cli.md Outdated Show resolved Hide resolved
Co-authored-by: Antoine du Hamel <[email protected]>
@cjihrig cjihrig added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 18, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 18, 2024
@nodejs-github-bot
Copy link
Collaborator

@cjihrig cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 19, 2024

@cjihrig cjihrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Dec 19, 2024
@jakecastelli jakecastelli added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 20, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 20, 2024
@nodejs-github-bot nodejs-github-bot merged commit 219b900 into nodejs:main Dec 20, 2024
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 219b900

@cjihrig cjihrig deleted the iso branch December 20, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants