v20.18.1 proposal #55879
Merged
v20.18.1 proposal #55879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #55349 Refs: nodejs/Release#999 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]>
To save time, the `.github/workflows/doc.yml` workflow runs with a pre-built Node.js. The switch of `lts/*` to Node.js 22 has broken this workflow for Node.js 20 and 18 due to a mismatch in globals. Pin the version of Node.js back to 20. PR-URL: #55755 Fixes: #55754 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Co-authored-by: Michaël Zasso <[email protected]> PR-URL: #54553 Backport-PR-URL: #55213 Fixes: #52298 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Refs: #54553
PR-URL: #55199 Backport-PR-URL: #55265 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
|
Review requested:
|
nodejs-github-bot
added
meta
marco-ippolito
added
release
This was referenced Nov 16, 2024
marco-ippolito
added
needs-ci
github-actions
bot
removed
the
request-ci
|
I think #55170 (comment) is still going to be an issue. |
|
Should I just drop the npm update? |
Refs: #54646 - Add instructions to update how process.versions is reported as I missed that in a recent addition. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #54792 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
PR-URL: #54951 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #54845 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Specifically, `delete Array.prototype.lastIndexOf` immediately crashes the REPL, as does deletion of a few other Array prototype methods. PR-URL: #31457 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: #54278 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #54401 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #53303 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #53746 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #54495 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #54386 Reviewed-By: Luigi Pinca <[email protected]>
`AF_INET` has been repeatedly set three times in the code. this should be redundant. removed the last two times. PR-URL: #54939 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #54835 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
marco-ippolito
force-pushed
the
v20.18.1-proposal
branch
from
4216e6d to
7017811
Compare
marco-ippolito
added
the
request-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@nodejs/undici is failing in CITGM looks like OpenSSL @mcollina Pino is also breaking @nodejs/releasers wdyt? CITGM says +81 but I cannot access the previous run |
|
We have this issue in the past and decided to ignore it; the thing is that OpenSSL changes the handling of the non-supported protocol. If we can ensure that will be the message from now on or add a wrapper around, we are good to go. Otherwise, ignoring the test for now should be ok. |
aduh95
approved these changes
Nov 20, 2024
|
As soon as release CI is ready I will proceed. |
richardlau
approved these changes
Nov 20, 2024
mertcanaltin
approved these changes
Nov 20, 2024
marco-ippolito
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Nov 20, 2024
marco-ippolito
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Nov 20, 2024
marco-ippolito
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Nov 20, 2024
github-merge-queue bot
pushed a commit
to nodejs/nodejs.org
that referenced
this pull request
Nov 20, 2024
26 tasks
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
Notable changes: doc: * add abmusse to collaborators (Abdirahim Musse) nodejs#55086 PR-URL: nodejs#55879
bmuenzenmeyer
pushed a commit
to nodejs/nodejs.org
that referenced
this pull request
Nov 21, 2024
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
Notable changes: doc: * add abmusse to collaborators (Abdirahim Musse) nodejs#55086 PR-URL: nodejs#55879
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2024-11-20, Version 20.18.1 'Iron' (LTS), @marco-ippolito
Notable Changes
7a8992b2d6] - doc: add abmusse to collaborators (Abdirahim Musse) #55086Commits
085c3441fe] - assert: show the diff when deep comparing data with a custom message (Giovanni) #5475901f0b0e7b4] - benchmark: adjust config for deepEqual object (Rafael Gonzaga) #55254a45537269b] - benchmark: rewrite detect-esm-syntax benchmark (Joyee Cheung) #552381a0d8ef64f] - benchmark: add no-warnings to process.has bench (Rafael Gonzaga) #551592be5d611ce] - benchmark: create benchmark for typescript (Marco Ippolito) #54904a2aa4fa477] - benchmark: include ascii to fs/readfile (Rafael Gonzaga) #5498809849105fe] - benchmark: add dotenv benchmark (Aviv Keller) #542786b3c24dbad] - buffer: fix out of range for toString (Jason Zhang) #54553f25a5b6dc4] - build: use rclone instead of aws CLI (Michaël Zasso) #556170bbeb605de] - build: fix notify-on-review-wanted action (Rafael Gonzaga) #553045b35836732] - build: include.nycrcin coverage workflows (Wuli Zuo) #55210f38d1e90e0] - build: notify via slack when review-wanted (Rafael Gonzaga) #551020b985ec4bb] - build: remove -v flag to reduce noise (iwuliz) #5502509f75b27a1] - build: display free disk space after build in the test-macOS workflow (iwuliz) #55025f25760c4a2] - build: add the option to generate compile_commands.json in vcbuild.bat (Segev Finer) #52279746e78c4f3] - Revert "build: upgrade clang-format to v18" (Chengzhong Wu) #5499467834ee646] - build: printRunning XYZ linter...for py and yml (Aviv Keller) #54386ae34e276a2] - build: pin doc workflow to Node.js 20 (Richard Lau) #55755d0e871a706] - build,win: add winget config to set up env (Hüseyin Açacak) #5472993ac799b6b] - cli: fix spacing for port range error (Aviv Keller) #544953ba2e7bf97] - Revert "console: colorize console error and warn" (Aviv Keller) #546772f678ea53b] - crypto: ensure invalid SubtleCrypto JWK data import results in DataError (Filip Skokan) #550415d28d98542] - deps: update undici to 6.20.0 (Node.js GitHub Bot) #553290c7f2fc421] - deps: update archs files for openssl-3.0.15+quic1 (Node.js GitHub Bot) #55184da15e7edf5] - deps: upgrade openssl sources to quictls/openssl-3.0.15+quic1 (Node.js GitHub Bot) #55184381f1f9d08] - deps: update archs files for openssl-3.0.14+quic1 (Node.js GitHub Bot) #5433648d643f78a] - deps: upgrade openssl sources to quictls/openssl-3.0.14+quic1 (Node.js GitHub Bot) #543367b1796803b] - deps: update timezone to 2024b (Node.js GitHub Bot) #550568f1956c588] - deps: update acorn-walk to 8.3.4 (Node.js GitHub Bot) #5495020501a7350] - deps: update corepack to 0.29.4 (Node.js GitHub Bot) #548450f81eafecc] - doc: fix Markdown linter (Antoine du Hamel) #55344df713f0a98] - Revert "doc: update test context.assert" (Antoine du Hamel) #55344fd6fc61d2c] - doc: add pmarchini to collaborators (Pietro Marchini) #55331b963db9ee2] - doc: fixevents.once()example usingAbortSignal(Ivo Janssen) #5514450b13bfb12] - doc: add onboarding details for ambassador program (Marco Ippolito) #5528427564b7811] - doc: fix initial default value of autoSelectFamily (Ihor Rohovets) #552459e7be23aa5] - doc: tweak onboarding instructions (Michael Dawson) #55212f412a029c3] - doc: update test context.assert (Pietro Marchini) #551862f7828debb] - doc: fix unordered error anchors (Antoine du Hamel) #55242d08e4c235b] - doc: mention addons to experimental permission (Rafael Gonzaga) #55166d65c2458dc] - doc: use correct dash in stability status (Antoine du Hamel) #55200d9839c16cf] - doc: fix link intest/README.md(Livia Medeiros) #551651ad659afa4] - doc: add esm examples to node:net (Alfredo González) #5513481ad69d50f] - doc: move the YAML changes element (sendoru) #551127a51a161be] - doc: fix the require resolve algorithm inmodules.md(chirsz) #5511780edcdf899] - doc: update style guide (Aviv Keller) #53223388c754dd2] - doc: add missing:torun()'sglobPatterns(Aviv Keller) #5513594302b6a76] - doc: add abmusse to collaborators (Abdirahim Musse) #5508627ff2da964] - doc: add note about--expose-internals(Aviv Keller) #52861df6dc753b7] - doc: removeparseREPLKeywordfrom REPL documentation (Aviv Keller) #547494baa5c4d10] - doc: change backporting guide with updated info (Aviv Keller) #537469947fc112f] - doc: add missing definitions tointernal-api.md(Aviv Keller) #53303a4586f0e94] - doc: update documentation for externalizing deps (Michael Dawson) #5479270504f8522] - doc: updaterequire(ESM)history and stability status (Antoine du Hamel) #551999d0041ac40] - doc: add release key for aduh95 (Antoine du Hamel) #553490c1666a52a] - events: allow null/undefined eventInitDict (Matthew Aitken) #54643453df77f99] - events: returncurrentTargetwhen dispatching (Matthew Aitken) #546420decaab9db] - fs: acknowledgesignaloption infilehandle.createReadStream()(Livia Medeiros) #5514800a2fc7166] - lib: moveSymbol[Async]Disposepolyfills tointernal/util(Antoine du Hamel) #548538e6b606ac4] - lib: remove lib/internal/idna.js (Yagiz Nizipli) #55050c96e5cb664] - lib: the REPL should survive deletion of Array.prototype methods (Jordan Harband) #31457748ed2e559] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #553008b8d35f015] - meta: bump mozilla-actions/sccache-action from 0.0.5 to 0.0.6 (dependabot[bot]) #55225d3441ff0c8] - meta: bump actions/checkout from 4.1.7 to 4.2.0 (dependabot[bot]) #552241c20908558] - meta: bump actions/setup-node from 4.0.3 to 4.0.4 (dependabot[bot]) #552238a529abd69] - meta: bump peter-evans/create-pull-request from 7.0.1 to 7.0.5 (dependabot[bot]) #552199053d210ab] - meta: add mailmap entry for abmusse (Abdirahim Musse) #55182db2496c125] - meta: add more information about nightly releases (Aviv Keller) #55084d2ce003b2f] - meta: addlinuxto OS labels in collaborator guide (Aviv Keller) #5498637b0bea247] - meta: remove never-used workflow trigger (Aviv Keller) #54983ae27e2dcd7] - meta: add links to alternative issue trackers (Aviv Keller) #544016e5d524b0f] - module: remove duplicated import (Aviv Keller) #549423a682cca03] - path: remove repetitive conditional operator inposix.resolve(Wiyeong Seo) #54835ac1cb8dfdb] - perf_hooks: add missing type argument to getEntriesByName (Luke Taher) #5476785b3edc83b] - repl: catch\vand\rin new-line detection (Aviv Keller) #54512df1f04999e] - src: decode native error messages as UTF-8 (Joyee Cheung) #5502486d718177a] - src: update clang-tidy and focus on modernization (Yagiz Nizipli) #537577d01b6a9c5] - src: cleanup per env handles directly without a list (Chengzhong Wu) #54993a730cdb622] - src: remove duplicate code setting AF_INET (He Yang) #54939f10d9ad283] - stream: treat null asyncIterator as undefined (Jason Zhang) #551196027084245] - test: maketest-loaders-workers-spawnedless flaky (Antoine du Hamel) #5517266a87d19bd] - test: update multiple assert tests to use node:test (James M Snell) #545855105188c47] - test: update wpt test for encoding (devstone) #5515181bcec0b82] - test: deflake test/pummel/test-timers.js (jakecastelli) #5509882c402265a] - test: deflake test-http-remove-header-stays-removed (Luigi Pinca) #5500478021701ed] - test: fix test-tls-junk-closes-server (Michael Dawson) #55089c908b8a2d8] - test: fix more tests that fail when path contains a space (Antoine du Hamel) #55088afc1628e73] - test: fixassertSnapshotwhen path contains a quote (Antoine du Hamel) #550877c88739b83] - test: fix some tests when path contains%(Antoine du Hamel) #55082eb4d468671] - Revert "test: mark test-fs-watch-non-recursive flaky on Windows" (Luigi Pinca) #55079bc7b5249d4] - test: maketest-runner-assertmore robust (Aviv Keller) #550366c2a1386f7] - test: update tls test to support OpenSSL32 (Michael Dawson) #5503096406610fa] - test: fixtest-vm-context-dont-contextifywhen path contains a space (Antoine du Hamel) #5502639a80eed4f] - test: adjust tls-set-ciphers for OpenSSL32 (Michael Dawson) #55016bd8fd4fceb] - test: addutil.stripVTControlCharacterstest (RedYetiDev) #54865333b5a02d0] - test: improve coverage for timer promises schedular (Aviv Keller) #53370f48992f433] - test: remove unused common utilities (RedYetiDev) #5482593a098c56d] - test: deflake test-http-header-overflow (Luigi Pinca) #54978f849cf677d] - test: fixsoucretosource(Aviv Keller) #550381a007ea814] - test: add asserts to validate test assumptions (Michael Dawson) #549976f53c096f8] - test: move test-http-max-sockets to parallel (Luigi Pinca) #54977aba9dc775e] - test: remove test-http-max-sockets flaky designation (Luigi Pinca) #54976ee5624bffe] - test: adjust key sizes to support OpenSSL32 (Michael Dawson) #549725c11a61140] - test: update test to support OpenSSL32 (Michael Dawson) #5496862f21470e4] - test: update DOM events web platform tests (Matthew Aitken) #54642426851705c] - test_runner: assert entry is a valid object (Edigleysson Silva (Edy)) #55231b1cad519d7] - test_runner: usetest:symbol on second print of parent test (RedYetiDev) #5495663c8f3d436] - test_runner: replace ansi clear with ansi reset (Pietro Marchini) #550130b3fb344f7] - tools: addpolyfilledoption toprefer-primordialsrule (Antoine du Hamel) #553188981309bd9] - tools: makechoco installscript more readable (Aviv Keller) #540027310abeae1] - tools: bump Rollup from 4.18.1 to 4.22.4 forlint-md(dependabot[bot]) #55093083311e8af] - tools: remove redudant code from eslint require rule (Aviv Keller) #54892ae4b2aece1] - tools: update error message for ICU in license-builder (Aviv Keller) #547423ebd31684d] - tools: update github_reporter to 1.7.1 (Node.js GitHub Bot) #54951397be8a10e] - tty: fix links for terminal colors (Aviv Keller) #54596a3c2ef9e98] - util: update ansi regex (Aviv Keller) #54865efdccc88a2] - watch: preserve output when gracefully restarted (Théo LUDWIG) #54323226836c5ac] - worker: throw InvalidStateError in postMessage after close (devstone) #55206f39ff4d14b] - worker: handle--input-typemore consistently (Antoine du Hamel) #5497930383ffb9a] - zlib: throw brotli initialization error from c++ (Yagiz Nizipli) #54698