test: use unusual chars in the path to ensure our tests are robust #48409
Conversation
|
Review requested:
|
nodejs-github-bot
added
the
meta
|
TIL GNU Make does not support files containing whitespaces nor |
|
Should we maybe avoid the hidden characters? I guess it's ok if GH only warns about them now but I don't want to see a permanent warning on the repo. |
I'm pretty sure it's just about the branch name for this PR, not related to the content of this PR. console.log("\u2020\u00A3\u00A7\u2122" === '†£§™'); // true |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #48409 +/- ##
=======================================
Coverage 88.54% 88.54%
=======================================
Files 657 657
Lines 190395 190395
Branches 36552 36550 -2
=======================================
+ Hits 168580 168590 +10
+ Misses 14993 14986 -7
+ Partials 6822 6819 -3 |
aduh95
force-pushed
the
†£§™
branch
3 times, most recently
from
a5e5921 to
c8b19c2
Compare
aduh95
force-pushed
the
†£§™
branch
2 times, most recently
from
78ec699 to
1c336ad
Compare
aduh95
force-pushed
the
†£§™
branch
3 times, most recently
from
34bafc0 to
522b401
Compare
| - name: Test | ||
| run: make run-ci -j4 V=1 TEST_CI_ARGS="-p actions --node-args='--test-reporter=spec' --node-args='--test-reporter-destination=stdout' --measure-flakiness 9" | ||
| run: make -C node run-ci -j4 V=1 TEST_CI_ARGS="-p actions --node-args='--test-reporter=spec' --node-args='--test-reporter-destination=stdout' --measure-flakiness 9" | ||
| - name: Re-run test in a folder whose name contains unusual chars |
There was a problem hiding this comment.
Wouldn't it mean we'll double the time to run the tests in the GH Actions?
There was a problem hiding this comment.
As you see in this PR, it adds about 10 minutes (a bit less on Linux)
github-actions
bot
removed
the
request-ci
Hopefully our tests should work without assuming the repo is cloned in path that contains unusual chars.