Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utf8 in filename is encoded as latin1 #332

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Utf8 in filename is encoded as latin1 #332

merged 4 commits into from
Dec 19, 2024

Conversation

jkoenig134
Copy link
Member

@jkoenig134 jkoenig134 commented Dec 19, 2024 •
edited
Loading

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

@jkoenig134 jkoenig134 added the bug Something isn't working label Dec 19, 2024
@jkoenig134 jkoenig134 enabled auto-merge (squash) December 19, 2024 08:31
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...modules/coreHttpApi/controllers/FilesController.ts 84.21% <100.00%> (ø)

@jkoenig134 jkoenig134 requested a review from tnotheis December 19, 2024 08:54
@jkoenig134 jkoenig134 merged commit e425dbb into main Dec 19, 2024
10 checks passed
@jkoenig134 jkoenig134 deleted the utf8-in-filename-is-encoded-as-latin1 branch December 19, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnotheis tnotheis tnotheis approved these changes

@britsta britsta Awaiting requested review from britsta

@Milena-Czierlinski Milena-Czierlinski Awaiting requested review from Milena-Czierlinski

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkoenig134 @tnotheis