Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #324

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Update dependencies #324

merged 1 commit into from
Dec 6, 2024

Conversation

sebbi08
Copy link
Contributor

@sebbi08 sebbi08 commented Dec 6, 2024 •
edited
Loading

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

@sebbi08 sebbi08 changed the title chore: update dependencies Update dependencies Dec 6, 2024
@sebbi08 sebbi08 added the dependencies Pull requests that update dependencies label Dec 6, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Milena-Czierlinski
Milena-Czierlinski approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@Milena-Czierlinski Milena-Czierlinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is dependabot already on vacation?

Magnus-Kuhn
Magnus-Kuhn reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@Magnus-Kuhn Magnus-Kuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ncu on main also showed that eslint can be updated to 9.16.0, was omitting this a deliberate choice?

@sebbi08 sebbi08 merged commit 8f2fa9a into main Dec 6, 2024
11 of 12 checks passed
@sebbi08 sebbi08 deleted the feature/update_dependencies branch December 6, 2024 13:55
@sebbi08
Copy link
Contributor Author

sebbi08 commented Dec 6, 2024

ncu on main also showed that eslint can be updated to 9.16.0, was omitting this a deliberate choice?

yes typescript eslint is not 9.x ready

@sebbi08
Copy link
Contributor Author

sebbi08 commented Dec 6, 2024

Is dependabot already on vacation?

No but there was a current security issue in one of our dependencies

@jkoenig134
Copy link
Member

Is dependabot already on vacation?

LMAO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Magnus-Kuhn Magnus-Kuhn Magnus-Kuhn left review comments

@Milena-Czierlinski Milena-Czierlinski Milena-Czierlinski approved these changes

@jkoenig134 jkoenig134 Awaiting requested review from jkoenig134

@britsta britsta Awaiting requested review from britsta

Assignees
No one assigned
Labels
dependencies Pull requests that update dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebbi08 @jkoenig134 @Magnus-Kuhn @Milena-Czierlinski