Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update naming convention #312

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Update naming convention #312

merged 2 commits into from
Nov 14, 2024

Conversation

jkoenig134
Copy link
Member

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@jkoenig134 jkoenig134 added the chore Some routine work like updating dependencies label Nov 14, 2024
@jkoenig134 jkoenig134 requested a review from tnotheis November 14, 2024 13:17
@jkoenig134 jkoenig134 enabled auto-merge (squash) November 14, 2024 13:20
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
packages/sdk/src/ConnectorClient.ts 100.00% <100.00%> (ø)
src/modules/webhooks/WebhooksModule.ts 95.94% <ø> (-0.06%) ⬇️

@jkoenig134 jkoenig134 merged commit b218207 into main Nov 14, 2024
12 checks passed
@jkoenig134 jkoenig134 deleted the update-naming-convention branch November 14, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnotheis tnotheis tnotheis approved these changes

Assignees
No one assigned
Labels
chore Some routine work like updating dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkoenig134 @tnotheis