Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/pubsub publisher #120

Merged
merged 24 commits into from
Nov 21, 2023
Merged

Feature/pubsub publisher #120

merged 24 commits into from
Nov 21, 2023

Conversation

jkoenig134
Copy link
Member

No description provided.

@jkoenig134 jkoenig134 marked this pull request as ready for review November 21, 2023 07:25
stnmtz
stnmtz previously requested changes Nov 21, 2023
View reviewed changes
Copy link

@stnmtz stnmtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check official PubSub naming vs. Pubsub

With this, we have multiple Eventing modules:

  • What happens if multiple modules are enabled in parallel?
  • We might need module-based log outputs

src/modules/pubsubPublisher/PubsubPublisherModule.ts Outdated Show resolved Hide resolved
src/modules/pubsubPublisher/PubsubPublisherModule.ts Outdated Show resolved Hide resolved
src/modules/pubsubPublisher/PubsubPublisherModule.ts Outdated Show resolved Hide resolved
src/modules/pubsubPublisher/PubsubPublisherModule.ts Outdated Show resolved Hide resolved
@jkoenig134
Copy link
Member Author

jkoenig134 commented Nov 21, 2023 •
edited
Loading

What happens if multiple modules are enabled in parallel?

all the modules will get all the events

We might need module-based log outputs

we have this already

@jkoenig134 jkoenig134 requested a review from stnmtz November 21, 2023 09:50
stnmtz
stnmtz reviewed Nov 21, 2023
View reviewed changes
.dev/pubsub/samplePubsubPublisher.ts Outdated Show resolved Hide resolved
.dev/pubsub/samplePubsubReader.ts Outdated Show resolved Hide resolved
src/modules/pubSubPublisher/PubSubPublisherModule.ts Outdated Show resolved Hide resolved
@jkoenig134 jkoenig134 requested a review from stnmtz November 21, 2023 10:11
@jkoenig134 jkoenig134 enabled auto-merge (squash) November 21, 2023 13:03
@jkoenig134 jkoenig134 merged commit 7ce4748 into main Nov 21, 2023
8 checks passed
@jkoenig134 jkoenig134 deleted the feature/pubsub-publisher branch November 21, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnotheis tnotheis tnotheis approved these changes

@slavistan slavistan Awaiting requested review from slavistan

@stnmtz stnmtz Awaiting requested review from stnmtz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkoenig134 @stnmtz @tnotheis