-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension of the Audit Log #705
Conversation
…b.com/nmshd/backbone into nmshdb-124-extension-of-the-audit-log
Important Review skippedAuto reviews are limited to specific labels. Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
At the moment this does not work. When I start the deletion process I get the {"@t":"2024-06-20T08:34:23.2118155Z","@mt":"Host terminated unexpectedly","@l":"Fatal","@x":"Backbone.BuildingBlocks.Application.Abstractions.Exceptions.NotFoundException: Identity not found. Make sure the ID exists and the record is not expired.\r\n at async Task Backbone.Modules.Devices.Application.Identities.Commands.LogDeletionProcess.Handler.Handle(LogDeletionProcessCommand request, CancellationToken cancellationToken) in C:/Code/backbone/Modules/Devices/src/Devices.Application/Identities/Commands/LogDeletionProcess/Handler.cs:line 18\r\n ... I know what the problem is but try figuring it out on your own. If you don't make it in an hour let me know and I'll help. |
Modules/Devices/src/Devices.Domain/Entities/Identities/IdentityDeletionProcessAuditLogEntry.cs
Outdated
Show resolved
Hide resolved
Modules/Devices/test/Devices.Application.Tests/Tests/Identities/IdentityDeleterTests.cs
Outdated
Show resolved
Hide resolved
Modules/Devices/test/Devices.Application.Tests/Tests/Identities/IdentityDeleterTests.cs
Outdated
Show resolved
Hide resolved
Modules/Challenges/test/Challenges.Application.Tests/Tests/Identities/IdentityDeleterTests.cs
Outdated
Show resolved
Hide resolved
Modules/Challenges/test/Challenges.Application.Tests/Tests/Identities/IdentityDeleterTests.cs
Outdated
Show resolved
Hide resolved
Modules/Files/test/Files.Application.Tests/Tests/Identities/IdentityDeleterTests.cs
Outdated
Show resolved
Hide resolved
Modules/Files/test/Files.Application.Tests/Tests/Identities/IdentityDeleterTests.cs
Outdated
Show resolved
Hide resolved
Modules/Devices/src/Devices.Domain/Entities/Identities/IdentityDeletionProcessAuditLogEntry.cs
Outdated
Show resolved
Hide resolved
…shd/backbone into nmshdb-124-extension-of-the-audit-log
…identity deletion job directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. Just the Admin UI needs to be implemented correctly by @stamenione. After that we are ready to merge this.
Nice. We just tested the identity deletion from scratch with Vladimir and can confirm it is working. |
AdminApi/src/AdminApi/ClientApp/src/app/services/identity-service/identity.service.ts
Outdated
Show resolved
Hide resolved
AdminApi/src/AdminApi/ClientApp/src/app/services/identity-service/identity.service.ts
Show resolved
Hide resolved
AdminApi/src/AdminApi/ClientApp/src/app/services/identity-service/identity.service.ts
Outdated
Show resolved
Hide resolved
Dismissing Nikola's review so we can merge even though he's on vacation
Readiness checklist