-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin UI: Overview of all Clients #619
Merged
jkoenig134
merged 137 commits into
main
from
NMSHDB-110-Administrator-Overview-of-all-Clients
May 3, 2024
Merged
Admin UI: Overview of all Clients #619
jkoenig134
merged 137 commits into
main
from
NMSHDB-110-Administrator-Overview-of-all-Clients
May 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: adapt the header appearance * chore: add new design for login box * chore: adapt login position in padding widget via screen size * chore: logic for displaying the error message for attempted login * chore: remove error message * chore: add error message * chore: change the button colors and add a text button * chore: remove Visibility widget * chore: add text style for text button * chore: change todo comment according to the flutter style * refactor: extract the app title to be a separate widget * refactor: extract text field to be reusable * chore: use new app title widget * chore: use custom text field * chore: make the text field fixed height * chore: rename variables and make them private * chore: update imports * chore: use extracted app title widget * chore: remove unnecessary widgets and center the card * chore: add custom colors and move login button to the bottom * chore: remove unused import * refactor: rename folder and files appropriately * refactor: extract sized box into a separate custom widget * refactor: extract elevated button into a separate custom widget * chore: make the variable private * chore: local variable should not start with underscore * chore: add DI for baseUrl * fix: untangle coding * fix: imports * fix: make CustomColors easier accessible * fix: make prettier * feat: add gaps * fix: rename file * refactor: remove CustomX, make whole logic with one variable * fix: bool logic * ci: add jkoenig134 as codeowner * chore: remove accidentally committet code * fix: undo change * refactor: simplify login screen * refactor: simplify app title * refactor: PR comments * chore: inline svg picture * chore: make multi line params last --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Julian König <[email protected]> Co-authored-by: Timo Notheisen <[email protected]>
…s://github.com/nmshd/backbone into NMSHDB-100-admin-ui-overview-of-all-identities
…s://github.com/nmshd/backbone into NMSHDB-100-admin-ui-overview-of-all-identities
Siolto
suggested changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not the scope of this PR but I highly recommend to use internationalization via l10n
ASAP.
AdminUi/apps/admin_ui/lib/home/clients_overview/modals/change_client_secret_dialog.dart
Outdated
Show resolved
Hide resolved
AdminUi/apps/admin_ui/lib/home/clients_overview/modals/change_client_secret_dialog.dart
Outdated
Show resolved
Hide resolved
AdminUi/apps/admin_ui/lib/home/clients_overview/modals/change_client_secret_dialog.dart
Outdated
Show resolved
Hide resolved
AdminUi/apps/admin_ui/lib/home/clients_overview/modals/create_client_dialog.dart
Outdated
Show resolved
Hide resolved
AdminUi/apps/admin_ui/lib/home/clients_overview/modals/create_client_dialog.dart
Outdated
Show resolved
Hide resolved
AdminUi/apps/admin_ui/lib/home/clients_overview/modals/remove_clients_dialog.dart
Show resolved
Hide resolved
AdminUi/apps/admin_ui/lib/home/clients_overview/modals/remove_clients_dialog.dart
Outdated
Show resolved
Hide resolved
AdminUi/apps/admin_ui/lib/home/clients_overview/modals/remove_clients_dialog.dart
Outdated
Show resolved
Hide resolved
tnotheis
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist
Description