fix: don't try to send a push notification to a non existing identity

nmshd · Dec 20, 2024 · 174f7f1 · 174f7f1
1 parent a1ddbfd
commit 174f7f1
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/...tion/DomainEvents/Incoming/ExternalEventCreated/ExternalEventCreatedDomainEventHandler.cs b/...tion/DomainEvents/Incoming/ExternalEventCreated/ExternalEventCreatedDomainEventHandler.cs
@@ -1,4 +1,3 @@
-using Backbone.BuildingBlocks.Application.Abstractions.Exceptions;
 using Backbone.BuildingBlocks.Application.Abstractions.Infrastructure.EventBus;
 using Backbone.BuildingBlocks.Application.PushNotifications;
 using Backbone.Modules.Devices.Application.Infrastructure.Persistence.Repository;
@@ -24,13 +23,9 @@ public async Task Handle(ExternalEventCreatedDomainEvent @event)
         if (@event.IsDeliveryBlocked)
             return;
 
-        var identity = await _identitiesRepository.FindByAddress(@event.Owner, CancellationToken.None) ?? throw new NotFoundException(nameof(Identity));
+        var identity = await _identitiesRepository.FindByAddress(@event.Owner, CancellationToken.None);
 
-        if (identity.Status != IdentityStatus.ToBeDeleted)
-            await _pushSenderService.SendNotification(
-                new ExternalEventCreatedPushNotification(),
-                SendPushNotificationFilter.AllDevicesOf(@event.Owner),
-                CancellationToken.None
-            );
+        if (identity != null && identity.Status != IdentityStatus.ToBeDeleted)
+            await _pushSenderService.SendNotification(new ExternalEventCreatedPushNotification(), SendPushNotificationFilter.AllDevicesOf(@event.Owner), CancellationToken.None);
     }
 }