feat: add inputs argument

[ghost]

This may help @nlordell.

Originally I thought params would be a good arg, but it wouldn't accept it due to prefix.

[ghost]

If you're happy with approach, I can add updated documentation.

[nlordell]

I liked your suggestion of calling this params to print out the createProxyWithNonce parameters.

The issue with it not working with the existing prefix flag is that #[arg(short)] defaults to using the first letter of there field name. You can fix that by specifying something else, for example:

Suggested change

	#[arg(short, long)]
	inputs: bool,
	#[arg(short = 'P', long)]
	params: bool,

This way, -P is used to print parameters, and -p is used for setting a prefix.

[nlordell]

Changes and approach looks good! Thanks for taking care of this :) Just a comment around the parameter name.

[ghost]

Hey @nlordell

Changed as advised.

Updated the docs, included a note about Etherscan.

There are two more commits:

1. To me it makes sense for creating the safe to be above Unsupported Chains, as it's the more common immediate usage
2. I suggest adding a note about safe 1.3.0. Currently it seems safe-service doesn't automatically pick up on the creation event from 1.4.1 safes - unless I'm understanding incorrectly, so it seems like a good idea to guide people to 1.3.0 vanity generation?

I realise now these should probably be different pull requests. Happy either way as this is your repo :)

[nlordell]

nit: extra newline

Suggested change

[nlordell]

To me it makes sense for creating the safe to be above Unsupported Chains, as it's the more common immediate usage

100% agree.

Currently it seems safe-service doesn't automatically pick up on the creation event from 1.4.1 safes

Oh no! Then yes, you should probably roll back to using v1.3.0 Safes for now. I also just double checked ant the wallet interface creates a v1.3.0 Safe as well, so it looks like v1.4.1 is not super well supported yet. Thanks for bringing this up!

[nlordell]

@kennedybaird - I rolled back the CLI to use Safe v1.3.0 because of compatibility concerns with the Safe infrastructure and Wallet interface. Thanks a bunch for bringing this up!

[ghost]

That's great, yeah, I ended up down a bit of a rabbit hole before figuring that out. Good work!

…

On Sun, Nov 12, 2023, 7:53 AM Nicholas Rodrigues Lordello < ***@***.***> wrote: @kennedybaird <https://github.com/kennedybaird> - I rolled back the CLI to use Safe v1.3.0 because of compatibility concerns with the Safe infrastructure and Wallet interface. Thanks a bunch for bringing this up! — Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE5DZE3GSMOUGJOWOSQTDGTYD7CSVAVCNFSM6AAAAAA7FGSBOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBWHA4TCMBQGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>