Skip to content
cbeckett edited this page Dec 3, 2012 · 11 revisions

#Refactoring ##FeatureEnvy ###Move Method ####LocalTaskController and SharedTaskController Method 'updateTask(Context context, Task task, int index)' was moved to parent class TaskController commit ##Long Method ###Extract Method

AddTaskActivity

Method numRequiredItems() extracted from createTask(). commit ####LocalTaskIOAdapter Method localTasksFromFile(Context context) extracted from readLocalLog. Improves modularity of tasks in method. commit ####TextItem Private class date() extracted from toString(). Extraction helps clarify converting Calendar to a String. commit ####CompletedTaskBaseAdapter Method holder(View convertView) extracted from getView(int position, View convertView, ViewGroup parent). Extracting method helps context of getView as it no longer needs to worry if the view is null, it can call the method to grab it. commit ####TaskItemAdapter Method 'private Class<?> classType(JsonElement json)' extracted from 'deserialize'. Extraction makes sense as it seperates responsibilities out of 'deserialize'. commit ####ImageItemArrayAdapter Private class date() extracted from getView(). Extraction helps clarify converting Calendar to a String. commit ####SharedTaskBaseAdapter Method holder(View convertView) extracted from getView(int position, View convertView, ViewGroup parent). Extracting method helps context of getView as it no longer needs to worry if the view is null, it can call the method to grab it. commit

Clone this wiki locally