Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dune 3.17.1 #1836

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Update Dune 3.17.1 #1836

merged 2 commits into from
Dec 20, 2024

Conversation

maiste
Copy link
Contributor

@maiste maiste commented Dec 19, 2024

This PR updates the dune version to 3.17.1. I have computed the sha using sha256sum as it is my first time with Nix, does it work, or should I do it another way?

@maiste maiste mentioned this pull request Dec 19, 2024
11 tasks
ocaml/default.nix Outdated Show resolved Hide resolved
@anmonteiro
Copy link
Collaborator

This PR updates the dune version to 3.17.1.

Thanks!

I have computed the sha using sha256sum as it is my first time with Nix, does it work, or should I do it another way?

Nix has its own hashing so in this case you'd need to run nix-prefetch-url --type sha256 <URL>

@anmonteiro anmonteiro merged commit b2765d0 into nix-ocaml:master Dec 20, 2024
10 of 23 checks passed
@maiste maiste deleted the update/dune-3.17 branch December 20, 2024 09:43
@maiste
Copy link
Contributor Author

maiste commented Dec 20, 2024

Thanks, I added the command to the wiki page of release process of Dune for future reference!

@ulrikstrid
Copy link
Collaborator

Ideally we should use the command:
nix hash to-sri --type sha256 $(nix-prefetch-url --type sha256 <URL>)

That would allow us to change to hash = ... instead of sha256 = ... which is the preferred option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants