Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos: Disable module if no persistent storage paths are defined or all are disabled #189

Merged
merged 2 commits into from
Jun 22, 2024

Conversation

talyz
Copy link
Collaborator

@talyz talyz commented Jun 9, 2024

Previously, we would always make some meaningless additions to activationScripts and such.

Also, remove some unused lib function imports from the module.

cc @0xf09f95b4

@jian-lin
Copy link
Member

jian-lin commented Jun 16, 2024

Related: #190 tries to avoid making side-effects to fileSystems when directories == [] (and files != [])

@talyz talyz force-pushed the nixos-disable-module branch from aa5e31c to d8feb6f Compare June 22, 2024 14:47
@talyz talyz merged commit 363b3e8 into master Jun 22, 2024
8 checks passed
@talyz talyz deleted the nixos-disable-module branch June 22, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants