Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper Home Manager module output (Updated #113) #181

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

SebTM
Copy link
Contributor

@SebTM SebTM commented Apr 27, 2024

Hey, I took care of the requested change in #113 but don't had permission to update the MR so why I created this 🙏🏻 Let me know if you would like something different - rebased on latest master.

README.org Show resolved Hide resolved
@SebTM
Copy link
Contributor Author

SebTM commented May 3, 2024

@talyz Any chance we can get this merged? 🙏🏻

Copy link
Contributor

@Misterio77 Misterio77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@talyz
Copy link
Collaborator

talyz commented Oct 18, 2024

Looks good to me! Can you please rebase on the latest master? I think merging now would create duplicate entries.

(cherry picked from commit fb2096bd7815dbd3c4f6ed5577a81e9ae722e35f)
mk3z and others added 2 commits October 21, 2024 17:13
(cherry picked from commit e8c3d195069584b27196a5f6c37cd166c65797a9)
@SebTM
Copy link
Contributor Author

SebTM commented Oct 21, 2024

Looks good to me! Can you please rebase on the latest master?

Done 🙏🏻

@SebTM
Copy link
Contributor Author

SebTM commented Oct 31, 2024

@talyz Can we get this merged? ✌🏻

@talyz talyz merged commit 32800b0 into nix-community:master Oct 31, 2024
4 checks passed
@SebTM SebTM deleted the patch-1 branch October 31, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants