Merge gameside changes into OSS scriptcomp #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, there's already #107 that died on the CI for reasons. I just retriggered that, if it passes I'll merge it first so this diff will be smaller. |
niv
approved these changes
Apr 4, 2024
|
True, but we don't have to be perfect. Try and keep the integration as nw.nim->game, and if something has to go the other way, handle it manually. Basically same as now, except hopefully better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, neverwinter.nim repo becomes the source of truth and is strictly newer than the game.
Testing
Scriptcomp test suite.
Licence