jQuery: Explore replacing effects with CSS transitions #156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
It's plausible that we could use the existing framework and reinterpret
#jquery_effect
. The stateless CSS transitions are relatively straightforward (fade/appear), while the stateful ones require more thought (toggle).Benefits
style
attribute from jQuery's timer-based callbacksif_visible()
checks necessary, when looking at CSS vs. JS for effectsDrawbacks