Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle migration path conflicts for identical database declarations #836

Conversation

davemooreuws
Copy link
Member

@davemooreuws davemooreuws commented Dec 19, 2024

When multiple database declarations occur, check if the migrations path conficts and error with action.

@davemooreuws davemooreuws marked this pull request as draft December 19, 2024 06:20
@davemooreuws davemooreuws force-pushed the fix/multiple-sql-migration-declarations branch from e281057 to 0100bce Compare December 19, 2024 23:32
@davemooreuws davemooreuws marked this pull request as ready for review December 19, 2024 23:32
@davemooreuws davemooreuws force-pushed the fix/multiple-sql-migration-declarations branch from 0100bce to 6bdc0f6 Compare December 19, 2024 23:36
@davemooreuws davemooreuws changed the title fix: handle migration paths for identical database declarations fix: handle migration path conflicts for identical database declarations Dec 20, 2024
@davemooreuws davemooreuws requested a review from raksiv December 20, 2024 01:50
tjholm
tjholm previously approved these changes Dec 22, 2024
raksiv
raksiv previously approved these changes Dec 22, 2024
@davemooreuws davemooreuws dismissed stale reviews from raksiv and tjholm via 44cbe78 December 22, 2024 22:36
@davemooreuws davemooreuws merged commit 69c84b2 into nitrictech:main Dec 22, 2024
5 checks passed
@davemooreuws davemooreuws deleted the fix/multiple-sql-migration-declarations branch December 22, 2024 22:53
@nitric-bot
Copy link
Contributor

🎉 This PR is included in version 1.55.15 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants